Skip to content

refactor(runner): resolve container type before .bin validation #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkoura merged 1 commit into from
Apr 22, 2026
Merged

refactor(runner): resolve container type before .bin validation #3430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions runner/runc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,15 @@ if [ $# -eq 0 ]; then
exit 2
fi

if [ -z "$CONTAINER_TYPE" ]; then
# Auto-detect: Alpine with bind-mounted /nix when available, NixOS otherwise.
if [ -d "/nix" ]; then
CONTAINER_TYPE="alpine"
else
CONTAINER_TYPE="nixos"
fi
fi

if command -v podman > /dev/null; then
container_manager="podman"
elif command -v docker > /dev/null; then
Expand Down Expand Up @@ -188,6 +197,12 @@ select_image() {
TAG="cardano-tests-nixos"
echo "NixOS container selected; /nix will be created inside the container."
;;
alpine)
echo "Host /nix found; mounting into Alpine container."
BASE_IMAGE="docker.io/library/alpine:${container_version}"
TAG="cardano-tests-alpine"
NIX_MOUNTS+=("-v" "/nix:/nix")
;;
ubuntu|debian|mint)
if [ ! -d "/nix" ]; then
echo "Error: Host /nix not found; --${container_type}-container requires /nix on the host." >&2
Expand All @@ -202,21 +217,8 @@ select_image() {
esac
echo "Host /nix found; mounting into ${container_type} container."
;;
"")
# Auto-detect: Alpine with bind-mounted /nix when available, NixOS otherwise.
if [ -d "/nix" ]; then
echo "Host /nix found; mounting into Alpine container."
BASE_IMAGE="docker.io/library/alpine:${container_version}"
TAG="cardano-tests-alpine"
NIX_MOUNTS+=("-v" "/nix:/nix")
else
echo "Host /nix not found; NixOS container will be used."
BASE_IMAGE="docker.io/nixos/nix:${container_version}"
TAG="cardano-tests-nixos"
fi
;;
*)
echo "Error: Unknown container type '${container_type}'. Expected one of: nixos, ubuntu, debian, mint, or empty for auto-detect." >&2
echo "Error: Unknown container type '${container_type}'. Expected one of: nixos, alpine, ubuntu, debian, or mint." >&2
return 1
;;
esac
Expand Down