Conversation
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
from
8405a4d to
5e3b82e
Compare
jorisdral
reviewed
Apr 6, 2026
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
from
5e3b82e to
8960737
Compare
Base automatically changed from
mheinzel/snapshot-test-backwards-compat
to
main
April 16, 2026 12:21
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
from
8960737 to
afdebde
Compare
jorisdral
approved these changes
Apr 23, 2026
Collaborator
jorisdral
left a comment
jorisdral
left a comment
There was a problem hiding this comment.
LGTM!
I think we should probably mention in the changelog that we added a new snapshot version. I wonder if we should also list it as a breaking change, because the snapshot format has changed... ideas?
Collaborator
Author
|
Good point. While the new version can still read old snapshots, we should make it clear that upgrading to the new version of |
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
from
afdebde to
b9a6cd0
Compare
mheinzel
force-pushed
the
mheinzel/empty-levels
branch
from
b9a6cd0 to
1246b46
Compare
jorisdral
reviewed
Apr 24, 2026
Comment on lines
+5
to
+11
| ### Breaking changes | ||
|
|
||
| * Move to snapshot version v2 due to changes to the internal table | ||
| representation. While this change is backwards compatible (i.e. new code | ||
| is still able to read old snapshots), be aware that v2 snapshots cannot be | ||
| read by older versions of `lsm-tree`. | ||
| See [PR #834](https://github.com/IntersectMBO/lsm-tree/pull/834). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #833, therefore currently still a draft PR.
As part of the work to allow migrating completed union levels, we introduce empty levels in the table structure. They don't get created yet, but will be useful for union migration. This is a similar change to what #823 did in the prototype.