Run separate debug/release mode golden tests for trace messages#840
Open
Run separate debug/release mode golden tests for trace messages#840
Conversation
mheinzel
force-pushed
the
mheinzel/golden-trace-messages
branch
from
d556e95 to
ede9f1a
Compare
The trace messages that get emitted differ between debug and release builds. Therefore, running the same test (with the same golden file of expected trace messages) both for debug and release builds will cause problems. To avoid these, we now have two separate tests, each with its own golden file, and only run the appropriate one depending on the build type. The only reason this did not lead to problems so far is that the test only inserted four entries into the table, not triggering any interesting internal events. However, we *will* emit internal messages once we start migrating the union level when a union is paid off (or we decide to test more interesting operations). Since we now can, I made sure that these tests now at least trigger the creation of a merge.
mheinzel
force-pushed
the
mheinzel/golden-trace-messages
branch
from
ede9f1a to
258458e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trace messages that get emitted differ between debug and release builds. Therefore, running the same test (with the same golden file of expected trace messages) both for debug and release builds will cause problems. To avoid these, we now have two separate tests, each with its own golden file, and only run the appropriate one depending on the build type.
The only reason this did not lead to problems so far is that the test only inserted four entries into the table, not triggering any interesting internal events. However, we will emit internal messages once we start migrating the union level when a union is paid off (or we decide to test more interesting operations). Since we now can, I made sure that these tests now at least trigger the creation of a merge.