Skip to content

Update ESLint 10 config#19

Merged
JSvandijk merged 3 commits into
JSvandijk:mainfrom
hogeheer499-commits:chore/eslint-10-flat-config
May 5, 2026
Merged

Update ESLint 10 config#19
JSvandijk merged 3 commits into
JSvandijk:mainfrom
hogeheer499-commits:chore/eslint-10-flat-config

Conversation

@hogeheer499-commits

Copy link
Copy Markdown
Contributor

Summary

Updates the repo for ESLint 10 by keeping Dependabot's eslint bump and adding a flat eslint.config.cjs file.

This supersedes #18, which is mergeable but currently fails CI because ESLint 10 no longer auto-loads .eslintrc.json.

Verification

Ran locally after npm install on this branch:

  • npm test passed
  • JS syntax checks passed
  • ESLint completed with 0 errors and the existing 2 server.js warnings
  • manifest.json check passed
  • release checks passed for version 1.1.0
  • HTML tests passed: 18/18
  • proxy smoke test passed

Notes

The old .eslintrc.json is left in place for now to keep the diff narrow; ESLint 10 uses eslint.config.cjs.

dependabot Bot and others added 2 commits April 28, 2026 18:39
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.1 to 10.2.1.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](eslint/eslint@v8.57.1...v10.2.1)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.2.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@JSvandijk

Copy link
Copy Markdown
Owner

Maintainer update on May 5, 2026:

I pushed an additional commit to finish the ESLint 10 migration instead of merging the dependency bump as-is.

What changed after review:

  • added the flat eslint.config.cjs migration
  • updated the declared Node engine to >=20.19.0, matching ESLint 10 dependency engines
  • moved CI and release workflows to Node 24
  • removed the two existing ESLint warnings in server.js
  • trimmed a few deprecated Android calls and switched the APK javac invocation to --release 11

Local verification on this PR head:

  • npm test passed with no ESLint warnings
  • cmd /c build-apk.bat passed and produced a dev-signed APK
  • javac --release 11 -Xlint:deprecation now reports only the remaining system-bar API warnings for the existing min/target SDK split

GitHub currently reports no PR checks for this fork branch, so the local verification above is the current evidence.

@JSvandijk JSvandijk merged commit 9702366 into JSvandijk:main May 5, 2026
JSvandijk pushed a commit that referenced this pull request May 5, 2026
Refresh upstream fit validation after #19. GitHub CI node-checks and android-build passed; local npm ci, npm test, and cmd /c build-apk.bat passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants