Intro SkikoFont abstraction for async font loading on all Skiko platforms#2787
Open
adamglin0 wants to merge 11 commits intoJetBrains:jb-mainfrom
Open
Intro SkikoFont abstraction for async font loading on all Skiko platforms#2787adamglin0 wants to merge 11 commits intoJetBrains:jb-mainfrom
adamglin0 wants to merge 11 commits intoJetBrains:jb-mainfrom
Conversation
…ility to customize font loading.
Author
|
@MatkovIvan @igordmn @eymar Could you assign reviewers for thsi PR, thanks. Additionally, SkiaParagraphIntrinsics currently lacks support for tracking asynchronous font resolution, so it can’t update once the fonts are ready. I plan to address this in a separate PR. We can now force a recompose by resizing the window, either programmatically or manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, Skiko-based platforms lacked a public API for async font loading. While
PlatformFontserves as the low-level font representation, it is not designed for extensibility by developers. By introducingSkikoFont, we provide a mechanism similar toAndroidFonton Android, allowing developers to:Fixes CMP-8231 Async font loading support for iOS targets
Testing
This should be tested by QA, but because the SkiaParagraphIntrinsics-related items lack a listener for TypefaceResult.Async, you need to resize the window so that the text can reflow and display correctly.
(If #2789 is merged, it will automatically display after loading, with no further action required.)
Release Notes
Features - Multiple Platforms