Skip to content

Track stale resolved fonts in SkiaParagraphIntrinsics#2789

Open
adamglin0 wants to merge 2 commits intoJetBrains:jb-mainfrom
adamglin0:fix/SkiaParagraphIntrinsics-missing-handling-for-hasStaleResolvedFonts
Open

Track stale resolved fonts in SkiaParagraphIntrinsics#2789
adamglin0 wants to merge 2 commits intoJetBrains:jb-mainfrom
adamglin0:fix/SkiaParagraphIntrinsics-missing-handling-for-hasStaleResolvedFonts

Conversation

@adamglin0
Copy link

This PR improves stale font detection in Skiko text layout by tracking non-immutable font resolution states.

  • Adds an optional onFontResolved callback path from ParagraphLayouter to ParagraphBuilder.
  • Reports non-immutable typeface resolution results during style conversion and span pre-resolution.
  • Tracks resolved typeface states in SkiaParagraphIntrinsics and implements hasStaleResolvedFonts to detect when previously resolved fonts become stale.

Fixes CMP-8231 Async font loading support for iOS targets

Release Notes

Fixes - Multiple Platforms

  • Detect stale resolved fonts in Skia paragraph intrinsics to better handle async font resolution updates.
    • Propagate font resolution callbacks through paragraph building and layout layers.

@adamglin0
Copy link
Author

This PR fixes the issue mentioned in #2787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant