test(api-student-resume-confirm): add validation edge case coverage#4824
test(api-student-resume-confirm): add validation edge case coverage#4824SujaanBhalla wants to merge 6 commits into
Conversation
|
🚨 Hey @SujaanBhalla, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
Hi Maintainers, The current CI failure appears unrelated to the changes in this PR. TypeScript is failing due to:
My changes only add validation test coverage in Could you please confirm whether this is caused by another failing test in the base branch? Thank you. |
|
Hi Maintainers, I have added the requested Could you please help identify the specific formatting issue or confirm whether there is any repository-specific formatting requirement I may be missing? Thank you. |
Aamod007
left a comment
There was a problem hiding this comment.
Summary
This PR cannot be approved because the Format . Lint . Typecheck . Test CI check is failing.
Required Changes
Issue 1
- Problem: The CI pipeline is failing.
- Impact: Cannot verify the test suite runs correctly.
- Required Fix: Rebase onto the latest
mainbranch and ensure all CI checks pass before requesting re-review.
Description
Fixes #4555
This PR adds additional test coverage for the student resume confirm API route.
Added test cases for:
These tests improve coverage for request validation and error handling scenarios.
Pillar
Visual Preview
N/A (test-only change)
Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.README.mdif I added a new theme or URL parameter.