Skip to content

test(api-student-resume-confirm): add validation edge case coverage#4824

Open
SujaanBhalla wants to merge 6 commits into
JhaSourav07:mainfrom
SujaanBhalla:test/api-student-resume-confirm-accessibility
Open

test(api-student-resume-confirm): add validation edge case coverage#4824
SujaanBhalla wants to merge 6 commits into
JhaSourav07:mainfrom
SujaanBhalla:test/api-student-resume-confirm-accessibility

Conversation

@SujaanBhalla
Copy link
Copy Markdown
Contributor

Description

Fixes #4555

This PR adds additional test coverage for the student resume confirm API route.

Added test cases for:

  • Missing githubUsername validation
  • githubUsername length limit validation (>39 characters)
  • Missing profile data validation
  • Missing name validation
  • Missing email validation

These tests improve coverage for request validation and error handling scenarios.

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A (test-only change)

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally.
  • I have run npm run format and npm run lint locally and resolved all errors.
  • My commits follow the Conventional Commits format.
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that I have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (Not Applicable).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

🚨 Hey @SujaanBhalla, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@SujaanBhalla
Copy link
Copy Markdown
Contributor Author

Hi Maintainers,

The current CI failure appears unrelated to the changes in this PR.

TypeScript is failing due to:

proxy.accessibility.test.ts(3,23): error TS2307: Cannot find module './proxy'

My changes only add validation test coverage in app/api/student/resume/confirm/route.test.ts.

Could you please confirm whether this is caused by another failing test in the base branch?

Thank you.

@SujaanBhalla
Copy link
Copy Markdown
Contributor Author

Hi Maintainers,

I have added the requested route.accessibility.test.ts file and attempted multiple formatting fixes, but the CI is still failing on the Prettier formatting check for this file.

Could you please help identify the specific formatting issue or confirm whether there is any repository-specific formatting requirement I may be missing?

Thank you.

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR cannot be approved because the Format . Lint . Typecheck . Test CI check is failing.

Required Changes

Issue 1

  • Problem: The CI pipeline is failing.
  • Impact: Cannot verify the test suite runs correctly.
  • Required Fix: Rebase onto the latest main branch and ensure all CI checks pass before requesting re-review.

@Aamod007 Aamod007 added mentor:Aamod007 GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ApiStudentResumeConfirmRoute-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

2 participants