test(sanitizer): verify Accessibility Standards & Screen Reader Aria Compliance#4832
Open
jeevitha-14s wants to merge 1 commit into
Open
test(sanitizer): verify Accessibility Standards & Screen Reader Aria Compliance#4832jeevitha-14s wants to merge 1 commit into
jeevitha-14s wants to merge 1 commit into
Conversation
Contributor
|
@jeevitha-14s is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
🚨 Hey @jeevitha-14s, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
Aamod007
requested changes
Jun 7, 2026
Collaborator
Aamod007
left a comment
There was a problem hiding this comment.
Summary
This PR cannot be approved because the Format . Lint . Typecheck . Test CI check is failing. Additionally, the test approach has quality issues.
Required Changes
Issue 1
- Problem: The CI pipeline is failing.
- Impact: Cannot verify the test suite runs correctly.
- Required Fix: Rebase onto the latest
mainbranch and resolve all CI failures.
Issue 2
- Problem: The tests import
sanitizeFontandsanitizeHexColorbut primarily test generic DOM accessibility patterns (creating HTML elements and checking ARIA attributes) rather than testing that the sanitizer preserves accessibility-related SVG attributes during sanitization. - Impact: Tests provide low-value coverage as they do not validate any real sanitizer behavior related to accessibility.
- Required Fix: Write tests that pass SVG content with accessibility attributes (role, aria-*, title, desc) through the sanitizer functions and verify the output preserves those attributes.
…n Reader Aria Compliance
9e06846 to
6c196f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4640
Adds isolated accessibility-focused test coverage for
lib/svg/sanitizer.tsby introducinglib/svg/sanitizer.accessibility.test.ts.Changes
Pillar
Visual Preview
No visual UI changes. This PR adds automated accessibility-focused test coverage only.
Checklist before requesting a review
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally.README.mdif I added a new theme or URL parameter.