test(ui): add accessibility and aria compliance tests for ProfileCard#4834
test(ui): add accessibility and aria compliance tests for ProfileCard#4834ThePriyanuj wants to merge 4 commits into
Conversation
|
🚨 Hey @ThePriyanuj, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
|
Hi @souravjhahind, I've verified the build constraints locally. The PR pipeline block is a false positive caused by pre-existing upstream issues on the
The new |
Aamod007
left a comment
There was a problem hiding this comment.
Summary
This PR cannot be approved because the Format . Lint . Typecheck . Test CI check is failing.
Required Changes
Issue 1
- Problem: The CI pipeline (Format/Lint/Typecheck/Test) is failing for this PR.
- Impact: Cannot verify correctness of the test suite; merging could introduce broken tests to the main branch.
- Required Fix: Rebase onto the latest
mainbranch and ensure all CI checks pass before requesting re-review.
Description
Fixes #2576
Implemented a robust suite of 5 isolated accessibility and screen-reader ARIA compliance unit tests for the
ProfileCardcomponent using Vitest.Coverage Details:
Pillar
🛠️ Other (Bug fix, refactoring, docs, testing)
Checklist
npx vitest run components/dashboard/ProfileCard.accessibility.test.tsx.