Skip to content

test(ui): add accessibility and aria compliance tests for ProfileCard#4834

Open
ThePriyanuj wants to merge 4 commits into
JhaSourav07:mainfrom
ThePriyanuj:test/profile-card-accessibility
Open

test(ui): add accessibility and aria compliance tests for ProfileCard#4834
ThePriyanuj wants to merge 4 commits into
JhaSourav07:mainfrom
ThePriyanuj:test/profile-card-accessibility

Conversation

@ThePriyanuj
Copy link
Copy Markdown
Contributor

Description

Fixes #2576

Implemented a robust suite of 5 isolated accessibility and screen-reader ARIA compliance unit tests for the ProfileCard component using Vitest.

Coverage Details:

  1. ARIA Labeling: Verified correct semantic landmarks and fallback text alternatives for avatar, sharing nodes, and structural targets.
  2. Focus Reachability: Confirmed that focusable elements maintain normal tab indexed parameters and visibility outlines.
  3. Tooltip Accessibility: Assured tooltip roles are accurately linked and announced via descriptive selectors.
  4. Dialog Traps: Monitored tab sequence pathing boundaries within custom profile overlays.
  5. Heading Order: Inspected DOM hierarchy layout structures to guarantee heading level sequences do not break.

Pillar

🛠️ Other (Bug fix, refactoring, docs, testing)

Checklist

  • I have read the CONTRIBUTING.md file.
  • My commits follow the Conventional Commits format.
  • I have made sure that I have only one commit to merge in this PR.
  • Isolated test suite passes cleanly locally via npx vitest run components/dashboard/ProfileCard.accessibility.test.tsx.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

🚨 Hey @ThePriyanuj, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@ThePriyanuj
Copy link
Copy Markdown
Contributor Author

Hi @souravjhahind,

I've verified the build constraints locally. The PR pipeline block is a false positive caused by pre-existing upstream issues on the main branch:

  1. npm run lint passes completely with 0 errors.
  2. The typecheck failures (168 errors across 46 files) are entirely caused by a global type-definition conflict with the repository's framer-motion configuration on layout elements (e.g., PRStatusDistribution, PRTrendChart, ProfileCard), which is completely independent of this isolated test file.

The new ProfileCard.accessibility.test.tsx file lints, compiles, and passes its isolated test runner flawlessly with 5/5 green assertions. Ready for review whenever the main infrastructure layout types are stabilized!

Copy link
Copy Markdown
Collaborator

@Aamod007 Aamod007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

This PR cannot be approved because the Format . Lint . Typecheck . Test CI check is failing.

Required Changes

Issue 1

  • Problem: The CI pipeline (Format/Lint/Typecheck/Test) is failing for this PR.
  • Impact: Cannot verify correctness of the test suite; merging could introduce broken tests to the main branch.
  • Required Fix: Rebase onto the latest main branch and ensure all CI checks pass before requesting re-review.

@Aamod007 Aamod007 added mentor:Aamod007 GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. labels Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. mentor:Aamod007 quality:clean PR follows clean coding practices, proper formatting, documentation, and maintainability standards. status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(ProfileCard-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

2 participants