Test/student accessibility#4865
Open
adityapandey4621 wants to merge 5 commits into
Open
Conversation
… Screen Reader Aria Compliance (Variation 4)
…reen Reader Aria Compliance (Variation 4)
…Reader Aria Compliance (Variation 4)
|
🚨 Hey @adityapandey4621, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
9f5ff3e to
464e034
Compare
464e034 to
b451cfe
Compare
5c6c93a to
1e57c1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds isolated unit and integration testing targeting the
StudentProfiletype definition, explicitly focusing on Accessibility Standards & Screen Reader Aria Compliance. Because the underlying file strictly exports type and interface contracts rather than rendering native HTML components, a simulatedStudentAccessibleViewproxy component was constructed inside the test scope. This proxy ingests a standardStudentProfilemock and dynamically maps the data shapes (names, emails, usernames) into robust ARIA DOM interfaces for compliance verification.Implementation details:
aria-labelledbyandaria-describedbycoordinate precision around the rendered values.focus:outline-2outline behaviors.student.namestrings and announcearia-hidden="false"when exposed.@testing-library/user-eventto enforce predictable and trap-free keyboard control paths mimicking typical tab ordering across interactive profiles.vitest.Fixes #4653
Pillar
Visual Preview
N/A (Test-only change verifying ARIA mappings for type structures)
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME) (N/A).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter (N/A).