test(HeroSection-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)#4866
Conversation
…een Reader Aria Compliance (Variation 4)
|
🚨 Hey @sheeeuWu, the CI Pipeline is failing on this PR and it has been marked as Please fix the issues before this can be reviewed. Here's how: 1. Run checks locally before pushing: npm run format:check # Check Prettier formatting
npm run lint # Run ESLint
npm run typecheck # TypeScript type check
npm run test # Run unit tests (Vitest)
npm run build # Verify production build passes2. Auto-fix common issues: npm run format # Auto-fix formatting with Prettier
npm run lint -- --fix # Auto-fix lint errors where possible3. Check the full failure log here: Once you push a fix and the CI passes, the |
068f700 to
52b777e
Compare
|
🎉 Congratulations @sheeeuWu! Your PR has been successfully merged. 🚀 Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.
Keep building! 💻✨ |
Description
Adds accessibility markup to
app/components/HeroSection.tsx(role="region", role="search", aria-label on input and buttons, aria-hidden on decorative elements) and createsapp/components/HeroSection.accessibility.test.tsxwith 5 unit tests verifying h1 heading hierarchy, search landmark, input announcement, button aria-labels, and decorative element hidingFixes #4563
Pillar
Visual Preview
N/A
Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/api/streak?user=YOUR_USERNAME).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat(themes): ...,fix(calculate): ...).README.mdif I added a new theme or URL parameter.