Skip to content

test(HeroSection-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)#4866

Merged
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
sheeeuWu:test/4563-hero-section-accessibility
Jun 8, 2026
Merged

test(HeroSection-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)#4866
JhaSourav07 merged 4 commits into
JhaSourav07:mainfrom
sheeeuWu:test/4563-hero-section-accessibility

Conversation

@sheeeuWu
Copy link
Copy Markdown
Contributor

@sheeeuWu sheeeuWu commented Jun 7, 2026

Description

Adds accessibility markup to app/components/HeroSection.tsx (role="region", role="search", aria-label on input and buttons, aria-hidden on decorative elements) and creates app/components/HeroSection.accessibility.test.tsx with 5 unit tests verifying h1 heading hierarchy, search landmark, input announcement, button aria-labels, and decorative element hiding

Fixes #4563

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

🚨 Hey @sheeeuWu, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@sheeeuWu sheeeuWu force-pushed the test/4563-hero-section-accessibility branch from 068f700 to 52b777e Compare June 8, 2026 11:17
@github-actions github-actions Bot added type:testing Adding, updating, or fixing tests and removed status:blocked This PR is blocked due to a failing CI check. labels Jun 8, 2026
@JhaSourav07 JhaSourav07 added GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. gssoc:approved PR has been reviewed and accepted for valid contribution points labels Jun 8, 2026
@JhaSourav07 JhaSourav07 merged commit 0e697dd into JhaSourav07:main Jun 8, 2026
7 checks passed
@github-actions github-actions Bot added this to the GSSoC 2026 milestone Jun 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 8, 2026

🎉 Congratulations @sheeeuWu! Your PR has been successfully merged. 🚀

Thank you for contributing to CommitPulse. Your work helps us build a better tool for the community.

⚠️ Important for GSSoC Contributors:
You are strictly advised to join our Discord Server as it is mandatory for all GSSoC participants. All important announcements, point claims, and community discussions happen there.

Keep building! 💻✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc:approved PR has been reviewed and accepted for valid contribution points GSSoC 2026 level:beginner Small changes Usually isolated fixes or simple UI/text updates. quality:exceptional Outstanding contribution with exceptional implementation quality, testing. type:testing Adding, updating, or fixing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(HeroSection-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

2 participants