Skip to content

test(SuccessGuide-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)#4876

Open
sheeeuWu wants to merge 1 commit into
JhaSourav07:mainfrom
sheeeuWu:test/4564-success-guide-accessibility
Open

test(SuccessGuide-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)#4876
sheeeuWu wants to merge 1 commit into
JhaSourav07:mainfrom
sheeeuWu:test/4564-success-guide-accessibility

Conversation

@sheeeuWu
Copy link
Copy Markdown
Contributor

@sheeeuWu sheeeuWu commented Jun 7, 2026

Description

Adds accessibility markup to app/components/SuccessGuide.tsx (role="region", aria-labelledby, aria-hidden on decorative elements, aria-label on steps grid and code snippet) and creates app/components/SuccessGuide.accessibility.test.tsx with 5 unit tests verifying region landmark, dismiss button announcement, steps grid visibility, step number sequence, and markdown snippet accessibility.

Fixes #4564

Pillar

  • 🎨 Pillar 1 — New Theme Design
  • 📐 Pillar 2 — Geometric SVG Improvement
  • 🕐 Pillar 3 — Timezone Logic Optimization
  • 🛠️ Other (Bug fix, refactoring, docs)

Visual Preview

N/A

Checklist before requesting a review:

  • I have read the CONTRIBUTING.md file.
  • I have tested these changes locally (localhost:3000/api/streak?user=YOUR_USERNAME).
  • I have run npm run format and npm run lint locally and resolved all errors (CI will fail otherwise).
  • My commits follow the Conventional Commits format (e.g., feat(themes): ..., fix(calculate): ...).
  • I have updated README.md if I added a new theme or URL parameter.
  • I have started the repo.
  • I have made sure that i have only one commit to merge in this PR.
  • The SVG output matches the CommitPulse "premium quality" aesthetic standard (no raw elements, smooth animations, correct fonts).
  • (Recommended) I joined the CommitPulse Discord community for contributor discussions, mentorship, and faster PR support.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 7, 2026

🚨 Hey @sheeeuWu, the CI Pipeline is failing on this PR and it has been marked as status:blocked.

Please fix the issues before this can be reviewed. Here's how:

1. Run checks locally before pushing:

npm run format:check   # Check Prettier formatting
npm run lint           # Run ESLint
npm run typecheck      # TypeScript type check
npm run test           # Run unit tests (Vitest)
npm run build          # Verify production build passes

2. Auto-fix common issues:

npm run format         # Auto-fix formatting with Prettier
npm run lint -- --fix  # Auto-fix lint errors where possible

3. Check the full failure log here:
👉 View CI Run

Once you push a fix and the CI passes, the status:blocked label will be removed automatically. 💪

@github-actions github-actions Bot added the status:blocked This PR is blocked due to a failing CI check. label Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:blocked This PR is blocked due to a failing CI check.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(SuccessGuide-accessibility): verify Accessibility Standards & Screen Reader Aria Compliance (Variation 4)

1 participant