Merged
Conversation
0cdf368 to
18bd338
Compare
nalimilan
reviewed
Jan 13, 2026
nalimilan
approved these changes
Jan 13, 2026
Member
|
IIUC we should release this soon and before JuliaStats/StatsBase.jl#986 so that when StatsBase is released nothing breaks, right? It could also make sense to check on JuliaHub whether there are other packages relying on this old behavior. I hadn't realized it would be so breaking. |
Member
Author
It was already released with v0.34.10 so I'll release this right away. I'll also make a code search on juliahub.com to see if I can find other similar use cases that would need to be adjusted. |
This was referenced Jan 13, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to and surfaced by JuliaStats/StatsBase.jl#986
After JuliaStats/StatsBase.jl#986, the show method here gives
and with the fix here it becomes