Skip to content

Fix show method for TableModels #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreasnoack merged 1 commit into from
Jan 13, 2026
Merged

Fix show method for TableModels #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/statsmodel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,17 +194,17 @@ function StatsAPI.coeftable(model::TableModels; kwargs...)
end

# show function that delegates to coeftable
function Base.show(io::IO, model::TableModels)
function Base.show(io::IO, ::MIME"text/plain", model::TableModels)
println(io, typeof(model))
println(io)
println(io, model.mf.f)
println(io)
try
println(io,"Coefficients:")
show(io, coeftable(model))
show(io, MIME"text/plain"(), coeftable(model))
catch e
if isa(e, MethodError) || isa(e, ErrorException) && occursin("coeftable is not defined", e.msg)
show(io, model.model)
show(io, MIME"text/plain"(), model.model)
else
rethrow(e)
end
Expand Down
26 changes: 22 additions & 4 deletions test/statsmodel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ struct DummyModTwo <: RegressionModel
end

StatsAPI.fit(::Type{DummyModTwo}, ::Matrix, ::Vector) = DummyModTwo("hello!")
Base.show(io::IO, m::DummyModTwo) = println(io, m.msg)
Base.show(io::IO, m::DummyModTwo) = print(io, m.msg)

@testset "stat model types" begin

Expand Down Expand Up @@ -164,8 +164,20 @@ Base.show(io::IO, m::DummyModTwo) = println(io, m.msg)
@test termnames(m) == ("y", ["(Intercept)", "x1", "x2", "x1 & x2"])

## show with coeftable defined
io = IOBuffer()
show(io, m)
@test repr("text/plain", m) == """
StatsModels.TableRegressionModel{DummyMod, Matrix{Float64}}

y ~ 1 + x1 + x2 + x1 & x2

Coefficients:
─────────────────────────
'beta' value
─────────────────────────
(Intercept) 1.0
x1 2.0
x2 3.0
x1 & x2 4.0
─────────────────────────"""

## with categorical variables
f2 = @formula(y ~ x1p)
Expand Down Expand Up @@ -234,7 +246,13 @@ Base.show(io::IO, m::DummyModTwo) = println(io, m.msg)

m2 = fit(DummyModTwo, f, d)
# make sure show() still works when there is no coeftable method
show(io, m2)
@test repr("text/plain", m2) == """
StatsModels.TableRegressionModel{DummyModTwo, Matrix{Float64}}

y ~ 1 + x1 + x2 + x1 & x2

Coefficients:
hello!"""
end

@testset "termnames" begin
Expand Down
Loading