Draft
Conversation
This is the first version, that supports both react 18 and 19.
Contributor
Author
|
Please note, that this change slightly changes the resulting import type { Widget, Obj } from 'scrivito';
export declare const ScrivitoBootstrapIconPicker: import("react").FunctionComponent<{
attribute?: string;
defaultValue?: string;
description?: string;
previewTitle?: string;
searchLabel?: string;
showClearButton?: boolean;
} & ({
obj: Obj;
page?: Obj;
widget?: never;
} | {
obj?: Obj;
page: Obj;
widget?: never;
} | {
obj?: never;
page?: never;
widget: Widget;
})>;to export declare function BootstrapIconPicker(props: {
defaultValue?: string;
disabled?: boolean;
onChange: (value?: string) => void;
searchLabel?: string;
showClearButton?: boolean;
value?: string;
}): import("react/jsx-runtime").JSX.Element;If I'm not mistaken this will most likely break the react 18 support. Ideas? |
|
APPROVED! Maybe keep this PR open (or just keep the branch around), so we can use it for further reviews? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows to try a local version of this package with
npm i file:../icon-pickerwithin the scrivito portal app, by updating react to version 19. Before this is done, runnpm install && npm run buildinicon-picker.