Skip to content

Local development (React 19 build)#11

Draft
apepper wants to merge 2 commits intomainfrom
local-development
Draft

Local development (React 19 build)#11
apepper wants to merge 2 commits intomainfrom
local-development

Conversation

@apepper
Copy link
Copy Markdown
Contributor

@apepper apepper commented Jan 12, 2026

This PR allows to try a local version of this package with npm i file:../icon-picker within the scrivito portal app, by updating react to version 19. Before this is done, run npm install && npm run build in icon-picker.

This is the first version, that supports both react 18 and 19.
@apepper
Copy link
Copy Markdown
Contributor Author

apepper commented Jan 12, 2026

Please note, that this change slightly changes the resulting dist/ScrivitoBootstrapIconPicker.d.ts from

import type { Widget, Obj } from 'scrivito';
export declare const ScrivitoBootstrapIconPicker: import("react").FunctionComponent<{
    attribute?: string;
    defaultValue?: string;
    description?: string;
    previewTitle?: string;
    searchLabel?: string;
    showClearButton?: boolean;
} & ({
    obj: Obj;
    page?: Obj;
    widget?: never;
} | {
    obj?: Obj;
    page: Obj;
    widget?: never;
} | {
    obj?: never;
    page?: never;
    widget: Widget;
})>;

to

export declare function BootstrapIconPicker(props: {
    defaultValue?: string;
    disabled?: boolean;
    onChange: (value?: string) => void;
    searchLabel?: string;
    showClearButton?: boolean;
    value?: string;
}): import("react/jsx-runtime").JSX.Element;

If I'm not mistaken this will most likely break the react 18 support. Ideas?

Copy link
Copy Markdown

@kostia kostia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, thank you 🤟

@kostia
Copy link
Copy Markdown

kostia commented Jan 14, 2026

APPROVED! Maybe keep this PR open (or just keep the branch around), so we can use it for further reviews?

@dcsaszar dcsaszar marked this pull request as draft February 2, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants