ci(github): split backend builds into separate CI jobs by Jvr2022 · Pull Request #11 · Jvr2022/seb-linux

Jvr2022 · 2026-04-08T16:59:20Z

Summary

What Changed

Verification

Summary by CodeRabbit

Tests
- Added runtime smoke tests to verify library dependencies and version compatibility across different web engine backends.
Chores
- Enhanced CI/CD pipeline to build and test multiple web engine configurations as separate jobs with distinct artifacts.
- Refactored code organization for improved maintainability.

chatgpt-codex-connector · 2026-04-08T16:59:26Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

coderabbitai · 2026-04-08T16:59:27Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ea3c7c06-0da9-4a23-bf88-e1325d107a3f

📥 Commits

Reviewing files that changed from the base of the PR and between eaa0956 and 7fd8066.

📒 Files selected for processing (3)

.github/workflows/ci.yml
src/browser_window.cpp
src/browser_window.h

💤 Files with no reviewable changes (1)

src/browser_window.h

✅ Files skipped from review due to trivial changes (1)

src/browser_window.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yml

📝 Walkthrough

Walkthrough

The CI workflow is restructured to build separate binaries for Qt WebEngine and WebKitGTK with distinct dependencies, uploading each as uniquely named artifacts. A new runtime-smoke job verifies runtime linkage of both binaries. Simultaneously, conditional compilation guards around QAuthenticator in source files are refactored for consistency.

Changes

Cohort / File(s)	Summary
CI/CD Workflow Restructuring `.github/workflows/ci.yml`	Split single `build` job into `build-qtwebengine` and `build-webkitgtk-fallback` with OS-specific dependencies. Added `runtime-smoke` job to verify runtime binary linkage against expected Qt framework dependencies before execution.
Source Code Preprocessor Refactoring `src/browser_window.cpp`, `src/browser_window.h`	Moved `QAuthenticator` forward declaration and include directive from conditional `#if SEB_HAS_QTWEBENGINE` block to unconditional scope, consolidating guard usage.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

build(qmake): support forced browser backend selection #10: Modifies conditional compilation around SEB_HAS_QTWEBENGINE and adjusts browser\_window's Qt-related includes, affecting the same preprocessor guard refactoring pattern.
feat(riscv64): add QtWebEngine-free compatibility mode #8: Updates preprocessor conditionals and Qt forward declarations in src/browser_window.(h|cpp), overlapping with the same conditional guard changes on QAuthenticator.

Poem

🐰 Two builds now flourish where once was one,
QtWebEngine and WebKitGTK run!
Guards rearranged in header's embrace,
Runtime smoke tests verify the place. ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description template sections (Summary, What Changed, Verification) are completely empty with no substantive content provided by the author.	Fill in all template sections with details about why the split was needed, what specifically changed in the workflow, and how the changes were verified.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'ci(github): split backend builds into separate CI jobs' accurately reflects the main change where CI workflows split into separate build jobs for different backends.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch ci/github-split-backend-builds

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

Splits CI backend builds into separate GitHub Actions jobs and adds a runtime smoke verification step intended to validate both Qt WebEngine and WebKitGTK builds.

Changes:

Split the single build job into build-qtwebengine and build-webkitgtk-fallback.
Add a runtime-smoke job that runs safe-exam-browser --version for both intended backends.
Add an ignore rule for docs/next-update-plan.md.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 4 comments.

File	Description
`.github/workflows/ci.yml`	Splits CI into separate backend build jobs and adds a runtime smoke job.
`.gitignore`	Ignores `docs/next-update-plan.md`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

🧹 Nitpick comments (1)

.github/workflows/ci.yml (1)
70-80: Consider using runtime packages instead of -dev packages.

The runtime-smoke job installs development packages (e.g., libqt6svg6-dev, qt6-base-dev) when only the runtime shared libraries are needed for executing the binaries. While -dev packages pull in runtime dependencies and this will work, it installs unnecessary headers and development files.

For a leaner runtime verification, consider installing just the runtime packages (e.g., libqt6svg6, libqt6core6, libqt6webenginecore6, etc.).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 70 - 80, The workflow's runtime-smoke
job installs development packages (libqt6svg6-dev, qt6-base-dev,
qt6-tools-dev-tools, qt6-webengine-dev, libwebkit2gtk-4.1-dev, libgtk-3-dev,
zlib1g-dev) but only needs runtime shared libraries; replace the -dev packages
with their runtime counterparts (e.g., libqt6svg6, libqt6core6,
libqt6webenginecore6, libwebkit2gtk-4.1-0 or equivalent, libgtk-3-0, zlib1g) in
the "Install runtime dependencies" step so the CI installs lean runtime packages
for the runtime-smoke job instead of development headers/tools.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 70-80: The workflow's runtime-smoke job installs development
packages (libqt6svg6-dev, qt6-base-dev, qt6-tools-dev-tools, qt6-webengine-dev,
libwebkit2gtk-4.1-dev, libgtk-3-dev, zlib1g-dev) but only needs runtime shared
libraries; replace the -dev packages with their runtime counterparts (e.g.,
libqt6svg6, libqt6core6, libqt6webenginecore6, libwebkit2gtk-4.1-0 or
equivalent, libgtk-3-0, zlib1g) in the "Install runtime dependencies" step so
the CI installs lean runtime packages for the runtime-smoke job instead of
development headers/tools.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 1400b522-3842-41b1-a3c6-fc28d05bb98f

📥 Commits

Reviewing files that changed from the base of the PR and between 49b2c4d and eaa0956.

📒 Files selected for processing (2)

.github/workflows/ci.yml
.gitignore

Copilot

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

t

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-08T17:26:51Z

+      - name: Build Qt WebEngine backend
+        run: ./scripts/build.sh


Both backend jobs call ./scripts/build.sh without explicitly forcing the intended engine. Since scripts/build.sh forwards args to qmake6 and seb-linux-qt.pro supports CONFIG+=force_qtwebengine / CONFIG+=force_webkitgtk, it would be more robust to pass the corresponding CONFIG flag here to guarantee the produced artifact is the Qt WebEngine build even if dependency detection changes or the runner image includes additional packages.

Copilot · 2026-04-08T17:26:51Z

+      - name: Build WebKitGTK fallback backend
        run: ./scripts/build.sh


This WebKitGTK job also runs ./scripts/build.sh without explicitly selecting the fallback engine. To ensure this artifact is truly the WebKitGTK build (and not Qt WebEngine due to auto-detection), consider passing CONFIG+=force_webkitgtk (supported by seb-linux-qt.pro) to the build script.

Copilot · 2026-04-08T17:26:51Z

+      - name: Verify Qt WebEngine runtime
        env:
          QT_QPA_PLATFORM: offscreen
-        run: ./build/bin/safe-exam-browser --version
+        run: |
+          chmod +x artifacts/qtwebengine/safe-exam-browser
+          artifacts/qtwebengine/safe-exam-browser --version
+
+      - name: Verify WebKitGTK runtime
+        env:
+          QT_QPA_PLATFORM: offscreen
+        run: |
+          chmod +x artifacts/webkitgtk/safe-exam-browser
+          artifacts/webkitgtk/safe-exam-browser --version


The runtime verification currently runs --version for both artifacts, which doesn’t validate that the downloaded binary matches the intended backend (Qt WebEngine vs WebKitGTK). Consider adding a lightweight assertion here (e.g., ldd/readelf check for linking against Qt6WebEngine* vs libwebkit2gtk*, or emitting backend info in --version) so the job fails if the wrong artifact is produced/uploaded.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ci(github): split backend builds into separate CI jobs

7c56daf

Copilot AI review requested due to automatic review settings April 8, 2026 16:59

Copilot started reviewing on behalf of Jvr2022 April 8, 2026 16:59 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml

Comment thread .github/workflows/ci.yml Outdated

ci(github): use upload-artifact v7 in backend workflow

eaa0956

Jvr2022 requested a review from Copilot April 8, 2026 17:13

Copilot started reviewing on behalf of Jvr2022 April 8, 2026 17:14 View session

coderabbitai Bot reviewed Apr 8, 2026

View reviewed changes

Copilot AI reviewed Apr 8, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

Jvr2022 and others added 2 commits April 8, 2026 19:18

Merge pull request #12 from Jvr2022/main

5815bb5

t

ci(github): use runtime packages in smoke job

10a3ca6

Jvr2022 requested a review from Copilot April 8, 2026 17:23

Copilot started reviewing on behalf of Jvr2022 April 8, 2026 17:24 View session

fix(browser): include QAuthenticator for webkitgtk fallback build

05ec311

Copilot AI reviewed Apr 8, 2026

View reviewed changes

ci(github): force backend builds and assert artifact linkage

7421e4a

Jvr2022 requested a review from Copilot April 8, 2026 17:28

Copilot started reviewing on behalf of Jvr2022 April 8, 2026 17:29 View session

Copilot AI reviewed Apr 8, 2026

View reviewed changes

ci(github): add missing Qt XML runtime dependency

7fd8066

Jvr2022 merged commit 00fbaa6 into main Apr 9, 2026
4 checks passed

coderabbitai Bot mentioned this pull request Apr 29, 2026

AppImage builds + fix false-positive in the anti-cheat + fix opening encrypted files. #19

Merged

		- name: Build WebKitGTK fallback backend
		run: ./scripts/build.sh

Conversation

Jvr2022 commented Apr 8, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Verification

Summary by CodeRabbit

Uh oh!

chatgpt-codex-connector Bot commented Apr 8, 2026

Uh oh!

coderabbitai Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Jvr2022 commented Apr 8, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 8, 2026 •

edited

Loading