Add OMI_collider and OMI_physics_body extension validation#202
Draft
aaronfranke wants to merge 2 commits into
Draft
Add OMI_collider and OMI_physics_body extension validation#202aaronfranke wants to merge 2 commits into
aaronfranke wants to merge 2 commits into
Conversation
12 tasks
aaronfranke
force-pushed
the
omi_collider
branch
3 times, most recently
from
December 10, 2022 19:32
c93d8f8 to
ef53adc
Compare
aaronfranke
force-pushed
the
omi_collider
branch
from
December 27, 2022 23:34
ef53adc to
4c476fc
Compare
aaronfranke
changed the title
aaronfranke
marked this pull request as ready for review
February 19, 2023 06:57
aaronfranke
marked this pull request as draft
August 6, 2023 06:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: This is incomplete, do not merge.
This PR adds validation for the
OMI_colliderandOMI_physics_bodyglTF extensions. This could be expanded further later, but the code that exists so far should be fully working (it successfully validates several test files).OMI's specs can be found here https://github.com/omigroup/gltf-extensions/tree/main/extensions/2.0
The Khronos glTF repo pull request can be found here: KhronosGroup/glTF#2258