Skip to content

OMI_collider#127

Merged
robertlong merged 1 commit into
omigroup:mainfrom
aaronfranke:OMI_collider
Jan 5, 2023
Merged

OMI_collider#127
robertlong merged 1 commit into
omigroup:mainfrom
aaronfranke:OMI_collider

Conversation

@aaronfranke

@aaronfranke aaronfranke commented Dec 9, 2022

Copy link
Copy Markdown
Member

This PR adds OMI_collider. It supersedes #118. This PR takes #118, overhauls the text to be more readable, updates the table of equivalent types in major engines, adds some discussed features, fixes and completes the schema, and adds a folder of example GLTF files.

Preview: https://github.com/aaronfranke/gltf-extensions/tree/OMI_collider/extensions/2.0/OMI_collider

I have the document listed as a Stage 2 proposal. This PR meets all of the requirements of Stage 1 and Stage 2.

Stage 1

  • High level outline published as a GitHub PR in this repository. (this PR)
  • Signed W3C CLA. (yes)

Stage 2

  • Previous requirements from Stage 1. (yes)
  • One metaverse implementation of the extension in development. (yes, in Godot Engine)
  • Valid and publicly accessible sample assets. (yes, see examples/ subfolder)
  • Valid JSON schema describing the extension in its entirety. (yes, should be valid)
  • Markdown document explaining the purpose, features, and properties of the extension. (yes, see the OMI_collider/README.md file in this PR)

Stage 3

  • Previous requirements from Stage 2. (yes)
  • Two or more metaverse implementations. (not yet, just Godot Engine)
  • glTF Validator implementation. (yes, here's the pull request)
  • Publicly available content creation tool for generating assets for this extension. (the Godot Engine implementation can export OMI_collider, although note that it will also export with OMI_physics_body)
  • All implementations, sample assets, and content creation tools should consume or produce assets that pass validation. (awaiting more implementations)

@mrmetaverse

Copy link
Copy Markdown
Member

Thanks for the demo yesterday (and last week too!) I can assign a reviewer and add this to the backlog to track on the main kanban. I know you had some questions about the process, and believe you all intend to discuss them during today's meeting, but feel free to update any changes in the comments.

@RangerMauve RangerMauve left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you for picking this up!

Comment thread extensions/2.0/OMI_collider/README.md
@robertlong

Copy link
Copy Markdown
Member

Vote to merge this PR passed with consensus
Screenshot 2023-01-05 at 3 15 28 PM

@robertlong robertlong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robertlong
robertlong merged commit 9ff3adc into omigroup:main Jan 5, 2023
@robertlong robertlong mentioned this pull request Jan 5, 2023
@aaronfranke
aaronfranke deleted the OMI_collider branch October 24, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants