Skip to content

[pull] master from getsentry:master#1990

Merged
pull[bot] merged 4 commits into
KingDEV95:masterfrom
getsentry:master
May 22, 2026
Merged

[pull] master from getsentry:master#1990
pull[bot] merged 4 commits into
KingDEV95:masterfrom
getsentry:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented May 22, 2026

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

NicoHinderling and others added 4 commits May 21, 2026 21:29
…gateway (#116078)

## Summary

The emmett API gateway (`src/apigw/proxy.py`) has its own path-based
`TIMEOUT_OVERRIDES` dict, separate from the Django gateway's
URL-name-based overrides that were added in #116076. Without this entry,
snapshot downloads fall back to the httpx client default of `read=60s`,
causing HTTP/2 stream errors on large snapshots (40K+ images).

Adds `(["/preprodartifacts/snapshots/", "/download/"], 90.0)` to match
the path pattern.

## Test plan

- [ ] Download a large snapshot (40K images) via `sentry-cli snapshots
download` and confirm it no longer fails with HTTP/2 stream errors after
~60s

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Replace the local `StyledMarkedText` wrapper (built on the legacy
`sentry/utils/marked` `MarkedText` component) with the new `<Markdown
/>` primitive from `@sentry/scraps/markdown` introduced in #115025.

This is the autofix surface rendered in the issue details sidebar and
the Seer drawer — the Solution card ("Plan"), Root Cause card, and the
streaming loading details. The `v3/styled.tsx` wrapper is no longer
needed and is removed.

No behavior change is intended. The new primitive renders each markdown
block via Scraps `Text`/`Heading`/`InlineCode`/etc. instead of
`dangerouslySetInnerHTML`, so visual rendering of the one-line summaries
and lists in `RootCauseCard` / `SolutionCard` may shift slightly —
please eyeball the cards in the sidebar and drawer during review.

Refs #115025
Wire `images_skipped` into the frontend `ChangeCounts` component so the
snapshots table displays skipped image counts when present (e.g., "5
skipped").

Also fixes a bug in the "No changes" early return: previously, a
selective snapshot run with 0 added/removed/changed but >0 skipped
images would show "No changes" instead of "N skipped". The condition now
checks `skipped === 0` as well, matching the backend behavior in VCS
status check templates.

Depends on #116073.

Co-authored-by: Claude <noreply@anthropic.com>
See getsentry/relay#6007. We want to test this
conversion method internally first to make sure the different attribute
naming doesn't break anything.

ref: INGEST-909.
@pull pull Bot locked and limited conversation to collaborators May 22, 2026
@pull pull Bot added the ⤵️ pull label May 22, 2026
@pull pull Bot merged commit 4a52f77 into KingDEV95:master May 22, 2026
@github-actions github-actions Bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels May 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⤵️ pull Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants