Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/apigw/proxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
(["/files/dsyms/"], 90.0),
(["/installablepreprodartifact/"], 90.0),
(["/objectstore/"], 90.0),
(["/preprodartifacts/snapshots/", "/download/"], 90.0),
]


Expand Down
2 changes: 2 additions & 0 deletions src/sentry/features/temporary.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,8 @@ def register_temporary_features(manager: FeatureManager) -> None:
manager.add("projects:relay-minidump-uploads", ProjectFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Enables the uploading of playstation attachments to the objectstore.
manager.add("projects:relay-playstation-uploads", ProjectFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
# Enables smarter measurements -> attributes conversion in Relay (see https://github.com/getsentry/relay/pull/6007)
manager.add("projects:relay-measurements-smart-conversion", ProjectFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)

# Enable lightweight RCA clustering write path (generate embeddings on new issues)
manager.add("organizations:supergroups-lightweight-rca-clustering-write", OrganizationFeature, FeatureHandlerStrategy.FLAGPOLE, api_expose=False)
Expand Down
1 change: 1 addition & 0 deletions src/sentry/relay/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"projects:relay-minidump-attachment-uploads",
"projects:relay-minidump-uploads",
"projects:relay-playstation-uploads",
"projects:relay-measurements-smart-conversion",
]

EXTRACT_METRICS_VERSION = 1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import styled from '@emotion/styled';

import {Flex} from '@sentry/scraps/layout';
import {Markdown} from '@sentry/scraps/markdown';
import {Text} from '@sentry/scraps/text';

import {type AutofixSection} from 'sentry/components/events/autofix/useExplorerAutofix';
import {ArtifactDetails} from 'sentry/components/events/autofix/v3/artifactDetails';
import {StyledMarkedText} from 'sentry/components/events/autofix/v3/styled';
import {LoadingIndicator} from 'sentry/components/loadingIndicator';
import {useAutoScroll} from 'sentry/utils/useAutoScroll';

Expand Down Expand Up @@ -40,11 +40,11 @@ export function ArtifactLoadingDetails({
}

if (block.message.content && block.message.content !== 'Thinking...') {
return <StyledMarkedText key={index} text={block.message.content} />;
return <Markdown key={index} raw={block.message.content} />;
}

if (block.message.thinking_content) {
return <StyledMarkedText key={index} text={block.message.thinking_content} />;
return <Markdown key={index} raw={block.message.thinking_content} />;
}

return null;
Expand Down
6 changes: 3 additions & 3 deletions static/app/components/events/autofix/v3/autofixPreviews.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {Tag} from '@sentry/scraps/badge';
import {LinkButton} from '@sentry/scraps/button';
import {Flex} from '@sentry/scraps/layout';
import {ExternalLink} from '@sentry/scraps/link';
import {Markdown} from '@sentry/scraps/markdown';
import {Text} from '@sentry/scraps/text';

import {
Expand All @@ -21,7 +22,6 @@ import {
isSolutionArtifact,
type AutofixSection,
} from 'sentry/components/events/autofix/useExplorerAutofix';
import {StyledMarkedText} from 'sentry/components/events/autofix/v3/styled';
import {LoadingIndicator} from 'sentry/components/loadingIndicator';
import {Placeholder} from 'sentry/components/placeholder';
import {IconOpen} from 'sentry/icons';
Expand Down Expand Up @@ -50,7 +50,7 @@ export function RootCausePreview({section}: ArtifactPreviewProps) {
<Text>{t('Finding the root cause\u2026')}</Text>
</Flex>
) : artifact?.data ? (
<StyledMarkedText text={artifact.data.one_line_description} />
<Markdown raw={artifact.data.one_line_description} />
) : (
<Text variant="muted">
{t(
Expand All @@ -76,7 +76,7 @@ export function SolutionPreview({section}: ArtifactPreviewProps) {
<Text>{t('Formulating a plan\u2026')}</Text>
</Flex>
) : artifact?.data ? (
<StyledMarkedText text={artifact.data.one_line_summary} />
<Markdown raw={artifact.data.one_line_summary} />
) : (
<Text variant="muted">
{t('Seer failed to generate a plan. This one is on us. Try running it again.')}
Expand Down
8 changes: 4 additions & 4 deletions static/app/components/events/autofix/v3/rootCauseCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {Fragment, useMemo} from 'react';

import {Button} from '@sentry/scraps/button';
import {Container, Flex} from '@sentry/scraps/layout';
import {Markdown} from '@sentry/scraps/markdown';
import {Text} from '@sentry/scraps/text';

import {
Expand All @@ -15,7 +16,6 @@ import {ArtifactDetails} from 'sentry/components/events/autofix/v3/artifactDetai
import {ArtifactLoadingDetails} from 'sentry/components/events/autofix/v3/artifactLoadingDetails';
import {AutofixEvidence} from 'sentry/components/events/autofix/v3/autofixEvidence';
import {AutofixResetPrompt} from 'sentry/components/events/autofix/v3/autofixResetPrompt';
import {StyledMarkedText} from 'sentry/components/events/autofix/v3/styled';
import {useAutofixSectionEvidence} from 'sentry/components/events/autofix/v3/useAutofixSectionEvidence';
import {useResetAutofixStep} from 'sentry/components/events/autofix/v3/useResetAutofixStep';
import {artifactToMarkdown} from 'sentry/components/events/autofix/v3/utils';
Expand Down Expand Up @@ -79,7 +79,7 @@ export function RootCauseCard({autofix, groupId, section}: RootCauseCardProps) {
/>
)}
<ArtifactDetails>
<StyledMarkedText text={artifact.data.one_line_description} />
<Markdown raw={artifact.data.one_line_description} />
</ArtifactDetails>
{artifact.data.five_whys?.length ? (
<Fragment>
Expand All @@ -88,7 +88,7 @@ export function RootCauseCard({autofix, groupId, section}: RootCauseCardProps) {
<Container as="ul" margin="0">
{artifact.data.five_whys.map((why, index) => (
<li key={index}>
<StyledMarkedText text={why} />
<Markdown raw={why} />
</li>
))}
</Container>
Expand All @@ -99,7 +99,7 @@ export function RootCauseCard({autofix, groupId, section}: RootCauseCardProps) {
<Container as="ol" margin="0">
{artifact.data?.reproduction_steps.map((step, index) => (
<li key={index}>
<StyledMarkedText text={step} />
<Markdown raw={step} />
</li>
))}
</Container>
Expand Down
6 changes: 3 additions & 3 deletions static/app/components/events/autofix/v3/solutionCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {Fragment, useMemo} from 'react';

import {Button} from '@sentry/scraps/button';
import {Container, Flex} from '@sentry/scraps/layout';
import {Markdown} from '@sentry/scraps/markdown';
import {Text} from '@sentry/scraps/text';

import {
Expand All @@ -14,7 +15,6 @@ import {ArtifactCard} from 'sentry/components/events/autofix/v3/artifactCard';
import {ArtifactDetails} from 'sentry/components/events/autofix/v3/artifactDetails';
import {ArtifactLoadingDetails} from 'sentry/components/events/autofix/v3/artifactLoadingDetails';
import {AutofixResetPrompt} from 'sentry/components/events/autofix/v3/autofixResetPrompt';
import {StyledMarkedText} from 'sentry/components/events/autofix/v3/styled';
import {useResetAutofixStep} from 'sentry/components/events/autofix/v3/useResetAutofixStep';
import {artifactToMarkdown} from 'sentry/components/events/autofix/v3/utils';
import {IconList} from 'sentry/icons/iconList';
Expand Down Expand Up @@ -74,7 +74,7 @@ export function SolutionCard({autofix, section}: SolutionCardProps) {
/>
)}
<ArtifactDetails>
<StyledMarkedText text={artifact.data.one_line_summary} />
<Markdown raw={artifact.data.one_line_summary} />
</ArtifactDetails>
{artifact.data.steps ? (
<ArtifactDetails>
Expand All @@ -83,7 +83,7 @@ export function SolutionCard({autofix, section}: SolutionCardProps) {
{artifact.data.steps.map((step, index) => (
<li key={index}>
<Flex direction="column">
<StyledMarkedText text={step.title} />
<Markdown raw={step.title} />
<Text size="sm" variant="muted">
{step.description}
</Text>
Expand Down
10 changes: 0 additions & 10 deletions static/app/components/events/autofix/v3/styled.tsx

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ function makeBuild(
images_removed: 0,
images_changed: 3,
images_unchanged: 19,
images_skipped: 0,
},
...overrides,
};
Expand Down Expand Up @@ -117,6 +118,7 @@ describe('PreprodBuildsSnapshotTable', () => {
images_removed: 0,
images_changed: 3,
images_unchanged: 19,
images_skipped: 0,
},
})
),
Expand All @@ -137,6 +139,7 @@ describe('PreprodBuildsSnapshotTable', () => {
images_removed: 0,
images_changed: 0,
images_unchanged: 0,
images_skipped: 0,
},
})
),
Expand Down Expand Up @@ -168,6 +171,7 @@ describe('PreprodBuildsSnapshotTable', () => {
images_removed: 0,
images_changed: 0,
images_unchanged: 20,
images_skipped: 0,
},
})
),
Expand Down
8 changes: 7 additions & 1 deletion static/app/components/preprod/preprodBuildsSnapshotTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,20 @@ function ChangeCounts({
removed,
changed,
unchanged,
skipped,
comparisonState,
}: {
added: number;
changed: number;
comparisonState: SnapshotComparisonState | null | undefined;
removed: number;
skipped: number;
unchanged: number;
}) {
if (comparisonState !== 'success') {
return <Text variant="muted">{'–'}</Text>;
}
if (added === 0 && removed === 0 && changed === 0) {
if (added === 0 && removed === 0 && changed === 0 && skipped === 0) {
return (
<Text size="sm" variant="muted">
{t('No changes')}
Expand All @@ -62,6 +64,9 @@ function ChangeCounts({
if (unchanged > 0) {
parts.push(t('%s unchanged', unchanged));
}
if (skipped > 0) {
parts.push(t('%s skipped', skipped));
}
return (
<Text size="sm" variant="muted">
{parts.join(', ')}
Expand Down Expand Up @@ -113,6 +118,7 @@ export function PreprodBuildsSnapshotTable({
removed={info?.images_removed ?? 0}
changed={info?.images_changed ?? 0}
unchanged={info?.images_unchanged ?? 0}
skipped={info?.images_skipped ?? 0}
comparisonState={info?.comparison_state}
/>
</SimpleTable.RowCell>
Expand Down
1 change: 1 addition & 0 deletions static/app/views/preprod/types/buildDetailsTypes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -211,5 +211,6 @@ interface SnapshotComparisonInfo {
images_added: number;
images_changed: number;
images_removed: number;
images_skipped: number;
images_unchanged: number;
}
Loading