fix: add web versioning#60
Conversation
| USER_PROVIDED_ES_SCRIPTS_DIR_PATH = USER_PROVIDED_SCRIPTS_DIR_PATH / "es" | ||
| USER_PROVIDED_SCRIPTS_SERVE_URL_PREFIX = Path("__trame_client_external_scripts") | ||
| USER_PROVIDED_SCRIPTS_SERVE_URL_PREFIX = Path( | ||
| f"__trame_client_external_scripts_{__version__}" |
There was a problem hiding this comment.
The external scripts are independent of the version of trame_client. So no need to have version in the URL.
There was a problem hiding this comment.
For external script if you want to prevent caching you can generate sha like we do in that file https://github.com/Kitware/trame-client/blob/master/trame_client/utils/web_module.py
There was a problem hiding this comment.
So then is there anything to web version ?
There was a problem hiding this comment.
normally the digest should already be used to enable appropriate caching/cache invalidation on file change. So I do not think there is something to be done here
There was a problem hiding this comment.
The version of trame-client should not affect the file your app serve as external script.
There was a problem hiding this comment.
I understand this, but doesn't this mean that there are no files to version for trame-client ?
There was a problem hiding this comment.
Indeed, the root directory (www) is the client code for the current version...
jourdain
left a comment
jourdain
left a comment
There was a problem hiding this comment.
No need to add version in that URL path
3 participants
No description provided.