Skip to content

fix: add web versioning #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jo-Byr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add web versioning #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion trame_client/module/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
from pathlib import Path
from trame_client import __version__

USER_PROVIDED_SCRIPTS_DIR_PATH = Path(__file__).with_name("user_provided_scripts")
USER_PROVIDED_UMD_SCRIPTS_DIR_PATH = USER_PROVIDED_SCRIPTS_DIR_PATH / "umd"
USER_PROVIDED_ES_SCRIPTS_DIR_PATH = USER_PROVIDED_SCRIPTS_DIR_PATH / "es"
USER_PROVIDED_SCRIPTS_SERVE_URL_PREFIX = Path("__trame_client_external_scripts")
USER_PROVIDED_SCRIPTS_SERVE_URL_PREFIX = Path(
f"__trame_client_external_scripts_{__version__}"

@jourdain jourdain May 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external scripts are independent of the version of trame_client. So no need to have version in the URL.

@jourdain jourdain May 26, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For external script if you want to prevent caching you can generate sha like we do in that file https://github.com/Kitware/trame-client/blob/master/trame_client/utils/web_module.py

@Jo-Byr Jo-Byr May 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then is there anything to web version ?

@bourdaisj bourdaisj Jun 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normally the digest should already be used to enable appropriate caching/cache invalidation on file change. So I do not think there is something to be done here

@jourdain jourdain Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of trame-client should not affect the file your app serve as external script.

@Jo-Byr Jo-Byr Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this, but doesn't this mean that there are no files to version for trame-client ?

@jourdain jourdain Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the root directory (www) is the client code for the current version...

)


def setup_handler_module(server):
Expand Down
Loading