Add deserialisation capabilities for raw JSON#184
Closed
BenCurran98 wants to merge 2 commits into
Closed
Conversation
BenCurran98
commented
Jan 14, 2025
| t₁, b₁ = time_ns(), gc_bytes() | ||
| Δt, Δb = t₁ - t₀, b₁ - b₀ | ||
| # make sure the deltas we report actually match the time elapsed - can cause problems if we go back to look at results at a later time | ||
| Δt, Δb = totmeasured(to) |
Contributor
Author
There was a problem hiding this comment.
I've added this in since I found if I deserialised a TimerOutput that I ran several hours ago, it showed the "total time" as being e.g. 7 hours, when the actual time was only 400 seconds. This way, the delta remains unaffected by time elapsed since the operation was run
Collaborator
There was a problem hiding this comment.
I've pulled this out into a specific fix here #187
Collaborator
There was a problem hiding this comment.
It was actually reverted. The behavior is intentional in some uses of this package
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I've had a go at adding some deserialisation capabilities for the current simple JSON functionality we have (with the
todictfunction). Ideally something like #136 (particularly the suggestion to use StructTypes and JSON3)would be much nicer to have, but this might do in the interim?