Fix total deltas#187
Merged
Merged
Conversation
Co-Authored-By: BenCurran98 <73566276+bencurran98@users.noreply.github.com>
Owner
|
To me showing 2s is correct. It's the time and allocations from when you created the timer. We don't start measuring the time from the first section but from when the time is created. I feel the same applies here. |
Owner
|
Ref #36 |
Collaborator
Author
|
Ok. I've blocked registration JuliaRegistries/General#125432 |
Collaborator
Author
|
I think there's a good argument for the totals to be representative of the contents of the report, particularly if I just thought this was a clear bug, so I'll revert and leave that to be resolved properly. |
IanButterworth
added a commit
that referenced
this pull request
Feb 19, 2025
This reverts commit 82f11d4.
IanButterworth
added a commit
that referenced
this pull request
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #184 by @BenCurran98
This PR
Master (note the total time is erroneously 2s in the 2nd print)