fix(a11y): associate Token and Memo labels in RemittanceForm#1272
Merged
ogazboiz merged 2 commits intoJun 28, 2026
Merged
Conversation
Wire label htmlFor to matching control ids so screen readers and tests can resolve accessible names for the token select and memo textarea. Closes LabsCrypt#1230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
htmlFor/idpairs for the Token select (token) and Memo textarea (memo) inRemittanceFormgetByLabelTextinstead of placeholder/display valueWhy
Labels were visually present but not programmatically associated with their controls (WCAG 1.3.1 / 4.1.2). Screen readers and Testing Library could not resolve accessible names for these fields.
Test plan
getByLabelText(/^Token/)getByLabelText(/^Memo/)npm test -- --testPathPattern=RemittanceForm.test(local env had incompletenode_modules)Closes #1230