Skip to content

fix(a11y): associate Token and Memo labels in RemittanceForm #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogazboiz merged 2 commits into from
Jun 28, 2026
Merged

fix(a11y): associate Token and Memo labels in RemittanceForm #1272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed6a0a9
fix(a11y): associate Token and Memo labels in RemittanceForm
kingbitnation Jun 28, 2026
1377327
style: format RemittanceForm textarea className for prettier
kingbitnation Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions frontend/src/app/components/remittance/RemittanceForm.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ describe("RemittanceForm", () => {
await user.type(addressInput, VALID_ADDRESS);
await user.type(amountInput, "100");

const memoInput = screen.getByPlaceholderText(
"Add a note for the recipient (max 28 characters)",
);
const memoInput = screen.getByLabelText(/^Memo/);
// Use fireEvent.change to bypass the textarea's maxLength attribute
fireEvent.change(memoInput, {
target: { value: "This is a very long memo that exceeds the limit" },
Expand All @@ -136,9 +134,7 @@ describe("RemittanceForm", () => {
const user = userEvent.setup();
render(<RemittanceForm onSuccess={mockOnSuccess} />);

const memoInput = screen.getByPlaceholderText(
"Add a note for the recipient (max 28 characters)",
);
const memoInput = screen.getByLabelText(/^Memo/);
await user.type(memoInput, "Test memo");

await waitFor(() => {
Expand All @@ -150,7 +146,7 @@ describe("RemittanceForm", () => {
const user = userEvent.setup();
render(<RemittanceForm onSuccess={mockOnSuccess} />);

const tokenSelect = screen.getByDisplayValue("USDC");
const tokenSelect = screen.getByLabelText(/^Token/);
expect(tokenSelect).toBeInTheDocument();

await user.selectOptions(tokenSelect, "EURC");
Expand Down
17 changes: 13 additions & 4 deletions frontend/src/app/components/remittance/RemittanceForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,14 @@ export function RemittanceForm({ onSuccess }: RemittanceFormProps) {

{/* Token Selection */}
<div className="space-y-2">
<label className="block text-sm font-semibold text-zinc-900 dark:text-zinc-50">
<label
htmlFor="token"
className="block text-sm font-semibold text-zinc-900 dark:text-zinc-50"
>
Token <span className="text-red-600">*</span>
</label>
<select
id="token"
value={token}
onChange={(e) => setToken(e.target.value)}
disabled={mutation.isPending}
Expand Down Expand Up @@ -212,18 +216,23 @@ export function RemittanceForm({ onSuccess }: RemittanceFormProps) {

{/* Memo (Optional) */}
<div className="space-y-2">
<label className="block text-sm font-semibold text-zinc-900 dark:text-zinc-50">
<label
htmlFor="memo"
className="block text-sm font-semibold text-zinc-900 dark:text-zinc-50"
>
Memo <span className="text-zinc-400">(optional)</span>
</label>
<textarea
id="memo"
placeholder="Add a note for the recipient (max 28 characters)"
value={memo}
onChange={(e) => handleMemoChange(e.target.value)}
disabled={mutation.isPending}
maxLength={28}
rows={2}
className={`w-full px-3 py-2 border rounded-lg bg-white dark:bg-zinc-900 text-zinc-900 dark:text-zinc-50 focus:outline-none focus:ring-2 focus:ring-indigo-600 dark:focus:ring-indigo-400 resize-none dark:border-zinc-700 ${errors.memo ? "border-red-600" : "border-zinc-300"
}`}
className={`w-full px-3 py-2 border rounded-lg bg-white dark:bg-zinc-900 text-zinc-900 dark:text-zinc-50 focus:outline-none focus:ring-2 focus:ring-indigo-600 dark:focus:ring-indigo-400 resize-none dark:border-zinc-700 ${
errors.memo ? "border-red-600" : "border-zinc-300"
}`}
/>
{errors.memo && (
<div className="flex items-start gap-2 text-sm text-red-600">
Expand Down
Loading