Fix buffer manager causing huge core dumps and hung processes on SIGSEGV#665
Merged
Conversation
…EGV (#664) Call madvise(..., MADV_DONTDUMP) on the buffer pool's virtual address reservation right after mmap, so the kernel skips this sparse multi-TB range during core dump generation. Without this, when a ladybug process crashes with coredumps enabled (the default on many distros via systemd-coredump/apport), the kernel walks the entire reservation in the dump path, turning every SIGSEGV into an unkillable process stuck at 100% CPU for 10+ minutes. MADV_DONTDUMP is available on Linux >= 3.4. macOS has no equivalent, so the call is guarded by #ifdef MADV_DONTDUMP.
adsharma
force-pushed
the
fix/madvise-dontdump
branch
from
ebfd874 to
9419289
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #664
Call madvise(..., MADV_DONTDUMP) on the buffer pool's virtual address reservation right after mmap, so the kernel skips this sparse multi-TB range during core dump generation.
Without this, when a ladybug process crashes with coredumps enabled (the default on many distros via systemd-coredump/apport), the kernel walks the entire reservation in the dump path, turning every SIGSEGV into an unkillable process stuck at 100% CPU for 10+ minutes.
MADV_DONTDUMP is available on Linux >= 3.4. macOS has no equivalent, so the call is guarded by #ifdef MADV_DONTDUMP.