Skip to content

Fix buffer manager causing huge core dumps and hung processes on SIGSEGV #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 1 commit into from
Jul 8, 2026
Merged

Fix buffer manager causing huge core dumps and hung processes on SIGSEGV #665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/storage/buffer_manager/vm_region.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,14 @@ VMRegion::VMRegion(PageSizeClass pageSizeClass, uint64_t maxRegionSize) : numFra
throw BufferManagerException(
"Mmap for size " + std::to_string(getMaxRegionSize()) + " failed.");
}
#ifdef MADV_DONTDUMP
// Tell the kernel not to include this virtual reservation in core dumps.
// Without this, the kernel walks the entire (potentially multi-TB) sparse
// reservation during crash dump generation, turning every SIGSEGV into an
// unkillable process stuck at 100% CPU in the dump path for minutes.
// MADV_DONTDUMP is available on Linux >= 3.4; macOS has no equivalent.
madvise(region, getMaxRegionSize(), MADV_DONTDUMP);
#endif
#endif
}

Expand Down
Loading