Reduce Warnings

[Lightning11wins]

This PR greatly reduces / nearly eliminates warnings when building centrallix, centrallix-lib, and their associated test suites with default configuration flags. This will reduce the number of bugs that make it to production in the future by making legitimate warnings far more obvious when building the project.

[Lightning11wins]

@greptileai Please review this code anyway.

[greptile-apps]

Greptile Summary

This PR removes unused variables, dead global structs (idcnt counters), and adds GCC diagnostic pragmas across 109 files to reduce build warnings. The most substantive logic change is fixing aposSetLimits in apos.c to properly propagate its return value from aposSetLimits_r (previously always returned 0).

Confidence Score: 5/5

This PR is safe to merge; all remaining findings are minor style suggestions with no impact on runtime correctness.

All findings are P2 style suggestions. The unused-variable and global struct removals are correct. The aposSetLimits bug fix is a genuine improvement. The puterr cast and the FirstCross/LastCross declarations are minor cleanup opportunities that do not affect behavior.

centrallix/tests/t_driver.c and centrallix/wgtr/apos.c have minor cleanup opportunities noted in inline comments.

Vulnerabilities

No security concerns identified.

Important Files Changed

Filename	Overview
centrallix-lib/src/mtask.c	Adds GCC diagnostic pragmas to suppress -Wuninitialized for intentional uninitialized buffer reads in stack setup routines
centrallix-lib/src/qprintf.c	Correctly changes char* to const char* for orig_src to fix discarded-qualifier warning
centrallix/wgtr/apos.c	Fixes aposSetLimits to propagate return value; removes unused changed variable; FirstCross/LastCross declarations remain with all assignments commented out
centrallix/netdrivers/net_http.c	Removes unused rval variable; nht_i_RestGet return value was assigned but never checked in original code
centrallix/tests/t_driver.c	Uses (int(*)(int))puterr cast to suppress type mismatch warning with tputs; proper fix is to change puterr parameter from char to int
centrallix/htmlgen/htdrv_alerter.c	Removes unused HTALRT global struct and id variable that was assigned but never referenced in the render function
centrallix/htmlgen/htdrv_form.c	Removes unused HTFORM global struct and id variable; clean dead-code removal
centrallix/multiquery/multiq_orderby.c	Removes unused pParamObjects objlist variable declaration from mqobFinish
centrallix/osdrivers/objdrv_qytree.c	Removes unused pStructInf find_inf and char* ptr variable declarations from qytQueryFetch
centrallix/htmlgen/htdrv_connector.c	Removes unused id variable and HTCONN global struct; idcnt was incremented but its value was never used

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Reduce Warnings] --> B[Remove unused variables]
    A --> C[Remove unused idcnt globals]
    A --> D[GCC diagnostic pragmas]
    A --> E[Bug fix: propagate return value]
    B --> B1[multiq_orderby.c: objlist]
    B --> B2[objdrv_qytree.c: find_inf, ptr]
    B --> B3[net_http.c: rval]
    B --> B4[12x htmlgen drivers: id vars]
    C --> C1[Remove idcnt struct from htmlgen drivers]
    D --> D1[mtask.c: suppress -Wuninitialized for stack bufs]
    E --> E1[apos.c: aposSetLimits returns rval not hardcoded 0]

Loading

_{Reviews (1): Last reviewed commit: "Fix warnings in centrallix test-obj test..." | Re-trigger Greptile}

[Lightning11wins]

Wow, sounds great.

This PR is cleared for human review.

[greptile-apps]

Too many files changed for review. (109 files found, 100 file limit)

[Lightning11wins]

The conversation is getting a little cluttered, so I think I should repost this.

This PR is cleared for human review.