Remove obsolete sys_osml widget.#99
Open
Lightning11wins wants to merge 1 commit into
Open
Conversation
It will be with us forever in our hearts (and also in the git tree).
Greptile SummaryThis PR removes the
Confidence Score: 5/5Safe to merge — the deleted widget was never fully implemented and all references have been removed from every layer of the stack. All four touched locations (JS file, C driver, Makefile, init call) are consistent stub removals. A full-repo search confirms no dangling references to sys_osml, sys-osml, or wgtosml remain anywhere in the codebase. No files require special attention.
|
| Filename | Overview |
|---|---|
| centrallix-os/sys/js/htdrv_sys_osml.js | JS client file for sys_osml widget deleted entirely; no remaining references in the repo. |
| centrallix/wgtr/wgtdrv_sys_osml.c | C server-side widget driver deleted entirely; contained only stub implementations with no logic. |
| centrallix/Makefile.in | Removes wgtdrv_sys_osml.o from the XWGTRDRIVERS build list; no other changes. |
| centrallix/wgtr/wgtr.c | Removes the wgtosmlInitialize() call from wgtrInitialize() and trailing blank lines at EOF. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[wgtrInitialize] -->|calls| B[wgtosmlInitialize removed]
A -->|calls| C[wgttabInitialize]
A -->|calls| D[wgttblInitialize]
B -->|registered| E[wgtrRegisterDriver: System:OSML Driver removed]
B -->|registered type| F[wgtrAddType: sys-osml removed]
G[Makefile.in] -->|compiled| H[wgtdrv_sys_osml.o removed]
I[htdrv_sys_osml.js removed] -->|client-side stub| J[cn_init function]
Reviews (1): Last reviewed commit: "Remove obsolete sys_osml widget." | Re-trigger Greptile
Contributor
Author
|
This PR is ready for human review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to our discussion on Riot, this widget is obsolete and was never fully implemented, so I've removed it to reduce clutter in the codebase.