Fix handling of missing extra-cmake-modules in Nix#283
Merged
nhktmdzhg merged 2 commits intoMay 15, 2026
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the fcitx5-lotus Nix package to make the extra-cmake-modules dependency more flexible by allowing it to be passed directly or retrieved from kdePackages. The review feedback suggests improving the safety of the attribute lookup within kdePackages using the ? operator to prevent potential missing attribute errors and recommends a more descriptive error message for the throw statement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle lỗi thiếu extra-cmake-modules cho nhiều system khác nhau. Fix issue #282
Tuỳ vào system khác nhau mà nó sẽ dùng
extra-cmake-moduleshoặckdePackages.extra-cmake-modules. PR này sẽ check cái nào available thì chọn cái đó.