Skip to content

Fix handling of missing extra-cmake-modules in Nix #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nhktmdzhg merged 2 commits into from
May 15, 2026
+12 −2
Merged

Fix handling of missing extra-cmake-modules in Nix #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
024532e
Merge pull request #281 from LotusInputMethod/dev
nhktmdzhg May 14, 2026
da6b952
fix(nix): handle missing extra-cmake-modules
justanoobcoder May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions nix/packages/fcitx5-lotus/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,29 @@
stdenv,
buildGoModule,
cmake,
extra-cmake-modules ? null,
fcitx5,
fetchFromGitHub,
gettext,
go,
hicolor-icon-theme,
kdePackages,
kdePackages ? null,
libinput,
libx11,
pkg-config,
python3,
qt6,
udev,
}:
let
ecm =
if extra-cmake-modules != null then
extra-cmake-modules
else if kdePackages != null then
kdePackages.extra-cmake-modules
else
throw "Cannot find extra-cmake-modules";
Comment thread
justanoobcoder marked this conversation as resolved.
in
stdenv.mkDerivation rec {
pname = "fcitx5-lotus";
version = "3.1.0";
Expand All @@ -30,7 +40,7 @@ stdenv.mkDerivation rec {

nativeBuildInputs = [
cmake
kdePackages.extra-cmake-modules
ecm
gettext
go
hicolor-icon-theme
Expand Down
Loading