[genhttp] Clean-up and simplify#82
Merged
Kaliumhexacyanoferrat merged 1 commit intoMDA2AV:mainfrom Feb 16, 2026
Merged
Conversation
MDA2AV
reviewed
Feb 16, 2026
| }) | ||
| .Post(async (IRequest request) => | ||
| var app = Inline.Create() | ||
| .Get("/echo", (IRequest request) => Echo(request)) |
Owner
There was a problem hiding this comment.
Shouldn't it be a Post here?
Collaborator
Author
There was a problem hiding this comment.
Ah - POST with no body is rather unintuitive 🤔
Owner
There was a problem hiding this comment.
Hmm indeed, I think initial idea was to send a body with it because malformed headers can cause some header data to leak to the body
Collaborator
Author
There was a problem hiding this comment.
Interestingly GET scored better because it returned a 405 then :D
Owner
There was a problem hiding this comment.
Oh snap, need to adjust those tests pass/fail criteria.. not simple because there is no explicit RFC for it
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.