-
Notifications
You must be signed in to change notification settings - Fork 5
[genhttp] Clean-up and simplify #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Kaliumhexacyanoferrat
merged 1 commit into
MDA2AV:main
from
Kaliumhexacyanoferrat:simplify-genhttp
Feb 16, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,35 @@ | ||
| using GenHTTP.Api.Content; | ||
| using GenHTTP.Api.Protocol; | ||
|
|
||
| using GenHTTP.Engine.Internal; | ||
|
|
||
| using GenHTTP.Modules.Functional; | ||
| using GenHTTP.Modules.Layouting; | ||
| using GenHTTP.Modules.Practices; | ||
|
|
||
| var port = args.Length > 0 && int.TryParse(args[0], out var p) ? p : 8080; | ||
| var port = (args.Length > 0 && ushort.TryParse(args[0], out var p)) ? p : (ushort)8080; | ||
|
|
||
| var echoHandler = Inline.Create() | ||
| .Any(async (IRequest request) => | ||
| { | ||
| await ValueTask.CompletedTask; | ||
| var sb = new System.Text.StringBuilder(); | ||
| foreach (var h in request.Headers) | ||
| sb.AppendLine($"{h.Key}: {h.Value}"); | ||
| return sb.ToString(); | ||
| }); | ||
|
|
||
| var rootHandler = Inline.Create() | ||
| .Get(async (IRequest request) => | ||
| { | ||
| await ValueTask.CompletedTask; | ||
| return "OK"; | ||
| }) | ||
| .Post(async (IRequest request) => | ||
| var app = Inline.Create() | ||
| .Get("/echo", (IRequest request) => Echo(request)) | ||
| .Post((Stream body) => RequestContent(body)) | ||
| .Any(() => StringContent()); | ||
|
|
||
| return await Host.Create() | ||
| .Handler(app) | ||
| .Defaults() | ||
| .Port(port) | ||
| .RunAsync(); | ||
|
|
||
| static string Echo(IRequest request) | ||
| { | ||
| var headers = new System.Text.StringBuilder(); | ||
|
|
||
| foreach (var h in request.Headers) | ||
| { | ||
| if (request.Content is not null) | ||
| { | ||
| using var reader = new StreamReader(request.Content); | ||
| return await reader.ReadToEndAsync(); | ||
| } | ||
| return ""; | ||
| }); | ||
|
|
||
| var layout = Layout.Create() | ||
| .Add("echo", echoHandler) | ||
| .Add(rootHandler); | ||
|
|
||
| await Host.Create() | ||
| .Handler(layout) | ||
| .Defaults() | ||
| .Port((ushort)port) | ||
| .RunAsync(); | ||
| headers.AppendLine($"{h.Key}: {h.Value}"); | ||
| } | ||
|
|
||
| return headers.ToString(); | ||
| } | ||
|
|
||
| static string StringContent() => "OK"; | ||
|
|
||
| static Stream RequestContent(Stream body) => body; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be a Post here?
https://mda2av.github.io/Http11Probe/add-a-framework/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah -
POSTwith no body is rather unintuitive 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm indeed, I think initial idea was to send a body with it because malformed headers can cause some header data to leak to the body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interestingly
GETscored better because it returned a405then :DThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh snap, need to adjust those tests pass/fail criteria.. not simple because there is no explicit RFC for it