fix: resetting busy on every skill container event#447
Open
LordMidas wants to merge 2 commits intodevelopmentfrom
Open
fix: resetting busy on every skill container event#447LordMidas wants to merge 2 commits intodevelopmentfrom
LordMidas wants to merge 2 commits intodevelopmentfrom
Conversation
In vanilla this.m.IsBusy and this.m.BusyStack are not reset for certain skill_container events e.g. onTargetHit. This may be relevant for players who play with Auto End Turn enabled which may cause the turn to end a bit too early. This commit adds a new parameter to `callSkillsFunction` which defaults to true and resets busy by default, but for specific functions we pass false for it. This includes the respective vanilla functions and some MSU added functions.
LordMidas
force-pushed
the
development
branch
2 times, most recently
from
6677ac8 to
ae825b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In vanilla this.m.IsBusy and this.m.BusyStack are not reset for certain skill_container events e.g. onTargetHit. This may be relevant for players who play with Auto End Turn enabled which may cause the turn to end a bit too early. This commit adds a new parameter to
callSkillsFunctionwhich defaults to true and resets busy by default, but for specific functions we pass false for it. This includes the respective vanilla functions and some MSU added functions.