fix(config): return a ManimColor from background_color property#4851
Open
Chessing234 wants to merge 1 commit into
Open
fix(config): return a ManimColor from background_color property#4851Chessing234 wants to merge 1 commit into
Chessing234 wants to merge 1 commit into
Conversation
The property is annotated as ManimColor but returned the raw stored value, which is a plain string when set via a config file or CLI rather than the setter. Wrap the value in ManimColor (lazy import to avoid the circular import) so callers can rely on ManimColor methods. Fixes ManimCommunity#4801 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog / Overview
config.background_coloris annotated-> ManimColorbut returned the raw stored value. When set via a config file or CLI (not the setter) that value is a plainstr, so callers relying onManimColormethods broke.Fix
Wrap the stored value in
ManimColorin the getter, using a lazy import to avoid the documented circular import (removes the stale# TODO). The setter already stored aManimColor, so the normal path is unchanged.Testing
tests/test_config.pypass.Fixes #4801
Made with Cursor