Skip to content

fix(config): return a ManimColor from background_color property #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Chessing234 wants to merge 1 commit into from
+5 −2
Closed

fix(config): return a ManimColor from background_color property #4851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions manim/_config/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,11 +1190,14 @@ def frame_rate(self) -> float:
def frame_rate(self, value: float) -> None:
self._d.__setitem__("frame_rate", value)

# TODO: This was parsed before maybe add ManimColor(val), but results in circular import
@property
def background_color(self) -> ManimColor:
"""Background color of the scene (-c)."""
return self._d["background_color"]
# Lazy import avoids a circular import at module load; guarantees the
# return value matches the annotation even if _d holds a raw value (#4801).
from manim.utils.color import ManimColor

return ManimColor(self._d["background_color"])

@background_color.setter
def background_color(self, value: Any) -> None:
Expand Down
Loading