helm(nginx): update dependency version#34
Open
shimoncohen wants to merge 4 commits into
Open
Conversation
shimoncohen
commented
Apr 5, 2026
shimoncohen
commented
Contributor
| Question | Answer |
|---|---|
| Bug fix | ✖ |
| New feature | ✖ |
| Breaking change | ✖ |
| Deprecations | ✖ |
| Documentation | ✖ |
| Tests added | ✖ |
| Chore | ✔ |
asafmas-rnd
requested changes
May 7, 2026
| # route.yaml -> annotations: -> haproxy.router.openshift.io/timeout: 30s | ||
| # The following value MUST be smaller to avoid unwanted behaviour (timeout with status code 200) | ||
| # Calculation: average (without cache) multiplied by "factor" which should correlates with response time while high load | ||
| proxy_read_timeout 3s; |
There was a problem hiding this comment.
proxy_read_timeout 3s;
Should be marked and located above
'#' proxy_read_timeout 3s;
| server { | ||
| listen {{ .Values.env.port }}; | ||
| # the domain name it will serve for | ||
| server_name heights; |
| # large_client_header_buffers 4 12288; # 12K | ||
| # fastcgi_read_timeout 300; | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }}; | ||
| add_header 'Access-Control-Allow-Headers' {{ .Values.nginx.nginx.allowedHeaders | default "*" | squote }}; |
There was a problem hiding this comment.
Why the -Max-Age is added below and here?
Why is it in both "server {" section and "location / " do we need both?
|
|
||
| location /liveness { | ||
| access_log off; | ||
| return 200; |
There was a problem hiding this comment.
Should we add "log_not_found off;" as is done in many other nginx services?
| if ($request_method = 'POST') { | ||
| add_header 'Access-Control-Allow-Origin' '*' always; | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }} always; | ||
| add_header 'Access-Control-Allow-Methods' 'POST, OPTIONS' always; |
There was a problem hiding this comment.
What about other methods?
If dem will have DELETE or PUT in the future?
| otel_span_attr opa.reason $opa_reason; | ||
| {{ end }} | ||
|
|
||
| proxy_pass http://heights; |
There was a problem hiding this comment.
Shouldn't it be {{ $serviceName }}? Do we have a service port configuration?
| @@ -78,7 +78,6 @@ nginx: | |||
| replicaCount: 1 | |||
| image: | |||
| repository: nginx | |||
| - name: nginx | ||
| version: 2.1.2 | ||
| version: 2.1.3 | ||
| repository: oci://acrarolibotnonprod.azurecr.io/helm/common |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.