-
Notifications
You must be signed in to change notification settings - Fork 0
helm(nginx): update dependency version #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| dependencies: | ||
| - name: nginx | ||
| repository: oci://acrarolibotnonprod.azurecr.io/helm/common | ||
| version: 2.1.2 | ||
| digest: sha256:83c525d0b74b939863f38f4a6716d1e7a3b1b955433cda7ee0e36f1af473d798 | ||
| generated: "2026-03-30T12:20:07.932221448+03:00" | ||
| version: 2.2.1 | ||
| digest: sha256:6f95133922a8a078f60abf1df94bb7dba8ed126ea5d1b1c41d223ef2f34e709b | ||
| generated: "2026-06-23T14:46:16.278212039+03:00" |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
|
|
||
| {{- $serviceName := include "service.fullname" . -}} | ||
| {{- $opalaEnabled := .Values.nginx.authorization.enabled }} | ||
| {{- $accessControlMaxAge := .Values.nginx.nginx.maxAge }} | ||
|
|
||
| split_clients "$otel_trace_id" $ratio_sampler { | ||
| {{ .Values.nginx.opentelemetry.ratio }}% on; | ||
|
|
@@ -32,6 +31,8 @@ server { | |
| # client_header_buffer_size 5M; | ||
| # large_client_header_buffers 4 12288; # 12K | ||
| # fastcgi_read_timeout 300; | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }}; | ||
| add_header 'Access-Control-Allow-Headers' {{ .Values.nginx.nginx.allowedHeaders | default "*" | squote }}; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why the -Max-Age is added below and here? |
||
|
|
||
| # OpenShift route is configured to time out HTTP requests that are longer than 30 seconds: | ||
| # route.yaml -> annotations: -> haproxy.router.openshift.io/timeout: 30s | ||
|
|
@@ -48,26 +49,26 @@ server { | |
| {{ include "heightsNginx.otelTrace" . | nindent 8 }} | ||
|
|
||
| if ($request_method = 'OPTIONS') { | ||
| add_header 'Access-Control-Allow-Origin' '*'; | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }}; | ||
| add_header 'Access-Control-Allow-Methods' 'POST, OPTIONS'; | ||
| # | ||
| # Custom headers and headers various browsers *should* be OK with but aren't | ||
| # | ||
| add_header 'Access-Control-Allow-Headers' 'DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type'; | ||
| add_header 'Access-Control-Allow-Headers' {{ .Values.nginx.nginx.allowedHeaders | default "*" | squote }}; | ||
| # | ||
| # Tell client that this pre-flight info is valid for 20 days | ||
| # | ||
| add_header 'Access-Control-Max-Age' {{ $accessControlMaxAge }}; | ||
| add_header 'Access-Control-Max-Age' {{ .Values.nginx.nginx.maxAge | default "86400" | squote }}; | ||
| add_header 'Content-Type' 'text/plain charset=UTF-8'; | ||
| add_header 'Content-Length' 0; | ||
| return 204; | ||
| } | ||
|
|
||
| if ($request_method = 'POST') { | ||
| add_header 'Access-Control-Allow-Origin' '*' always; | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }} always; | ||
| add_header 'Access-Control-Allow-Methods' 'POST, OPTIONS' always; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What about other methods? |
||
| add_header 'Access-Control-Allow-Headers' 'DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type' always; | ||
| add_header 'Access-Control-Max-Age' {{ $accessControlMaxAge }}; | ||
| add_header 'Access-Control-Allow-Headers' {{ .Values.nginx.nginx.allowedHeaders | default "*" | squote }} always; | ||
| add_header 'Access-Control-Max-Age' {{ .Values.nginx.nginx.maxAge | default "3600" | squote }}; | ||
| } | ||
|
|
||
| proxy_hide_header Set-Cookie; # ensures the header will not be passed back to the client | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| if ($request_method = 'POST') { | ||
| add_header 'Access-Control-Allow-Origin' {{ .Values.nginx.nginx.allowedOrigins | default "*" | squote }} always; | ||
| add_header 'Access-Control-Allow-Methods' 'POST, OPTIONS' always; | ||
| add_header 'Access-Control-Allow-Headers' {{ .Values.nginx.nginx.allowedHeaders | default "*" | squote }} always; | ||
| add_header 'Access-Control-Max-Age' {{ .Values.nginx.nginx.maxAge | default "3600" | squote }}; | ||
| } | ||
|
|
||
| proxy_hide_header Set-Cookie; # ensures the header will not be passed back to the client | ||
| proxy_ignore_headers Set-Cookie; # ensures that the header will not automatically disable caching within nginx | ||
| proxy_set_header Cookie ""; # ensures that a client cannot pass any prior cookies to the webapp and spoil your cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are the MC labels?