fix(network-controller): Only consider failover endpoints when using Infura#9125
Open
FrederikBolding wants to merge 3 commits into
Open
fix(network-controller): Only consider failover endpoints when using Infura#9125FrederikBolding wants to merge 3 commits into
FrederikBolding wants to merge 3 commits into
Conversation
FrederikBolding
commented
Jun 15, 2026
| ).toHaveBeenCalledWith({ | ||
| chainId, | ||
| error: expectedUnavailableError, | ||
| if (networkClientType !== NetworkClientType.Custom) { |
Member
Author
There was a problem hiding this comment.
This is hacky. Open to suggestions for how to improve it, but giving the massive number of tests this seemed OK...
FrederikBolding
temporarily deployed
to
default-branch
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Only add failover URLs to
RpcServiceChainwhen the network client being created is of typeInfura.I would recommend reviewing this with white-space diff turned off.
References
N/A
Checklist