chore(smart-transactions-controller): strip source-repo-only files#9132
Merged
cryptodev-2s merged 1 commit intoJun 15, 2026
Merged
Conversation
Removes files that will be replaced by monorepo-root equivalents or are no longer needed in the migrated package: - `.github/`, `.gitattributes`, `.gitignore` — handled at repo root - `.editorconfig`, `.nvmrc` — root-level - `.prettierrc.js`, `eslint.config.mjs` — replaced by root configs - `.yarn/`, `.yarnrc.yml`, `yarn.lock` — monorepo uses Yarn 4 at root - `scripts/` — source-repo release/preview scripts no longer needed Keeps: `src/`, `tests/`, `CHANGELOG.md`, `LICENSE`, `package.json`, `README.md`, `jest.config.js`, `tsconfig*.json`, `typedoc.json`, `setupJest.js`. Config files are replaced/wired up in PR #9. Per Phase B PR #8 of the package-migration-process-guide.
cryptodev-2s
temporarily deployed
to
default-branch
GitHub Actions
Inactive
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
approved these changes
Jun 15, 2026
cryptodev-2s
deleted the
chore/smart-transactions-controller-strip-source-repo-files
branch
This was referenced Jun 15, 2026
pull Bot
pushed a commit
to dmrazzy/core
that referenced
this pull request
Jun 15, 2026
…epo roots (MetaMask#9134) ## Explanation Phase B PR #9 of the [package migration process guide](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) for [\`@metamask/smart-transactions-controller\`](https://github.com/MetaMask/core/tree/main/merged-packages/smart-transactions-controller). ### Replaced - **\`tsconfig.json\`** — now extends \`../../tsconfig.packages.json\`. Lists references for the in-monorepo upstream \`@metamask/*\` deps and optional peers. \`noErrorTruncation\` and \`resolveJsonModule\` preserved from the source repo's tsconfig. - **\`tsconfig.build.json\`** — extends \`../../tsconfig.packages.build.json\` and mirrors the same references with \`tsconfig.build.json\` paths. - **\`jest.config.js\`** — merges into the root \`jest.config.packages.js\`. Preserves the package's coverage thresholds (branches 74.65, functions 88.18, lines 92.33, statements 91.89), \`setupJest.js\` setup, and \`testTimeout: 2500\`. ### Unchanged - **\`typedoc.json\`** — already matches the template (\`scripts/create-package/package-template/typedoc.json\`). - **\`setupJest.js\`** — kept as-is; may be removable in PR #10 since Node 18+ has native \`fetch\` and \`isomorphic-fetch\` is no longer strictly required. ### DevDependency added - \`deepmerge@^4.2.2\` (used by the new \`jest.config.js\`) Package is still in \`merged-packages/\` so \`yarn install\` doesn't include it; configs aren't exercised until Phase C PR #12 moves it into \`packages/\`. ## References - Prior steps: history merge (MetaMask#9130), CHANGELOG reset (MetaMask#9131), strip source-repo-only files (MetaMask#9132) - Migration process: [\`docs/processes/package-migration-process-guide.md\`](https://github.com/MetaMask/core/blob/main/docs/processes/package-migration-process-guide.md) ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Phase B PR #8 of the package migration process guide for `@metamask/smart-transactions-controller`.
Removes files that are either handled at the monorepo root or no longer needed once the package lives in core:
Kept (matches the guide's "Keep" list): `src/`, `tests/`, `CHANGELOG.md`, `LICENSE`, `package.json`, `README.md`, `jest.config.js`, `tsconfig*.json`, `typedoc.json`, `setupJest.js` (the last one will be decided in PR #9 when configs are replaced).
No code or runtime behaviour changes.
References
@metamask/smart-transactions-controllerhistory intomerged-packages/#9130), CHANGELOG reset (chore(smart-transactions-controller): reset CHANGELOG after migration #9131)Checklist