Correct the deep copy and testing system #22
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discordier
requested changes
Jan 26, 2026
| $widget | ||
| ->expects(self::any()) | ||
| ->method('import') | ||
| ->withConsecutive([Config::class, 'Config']); |
Member
There was a problem hiding this comment.
shouldn't this whole block rathe be:
$widget
->expects($this->once())
->method('import')
->with(Config::class, 'Config');
Member
Author
There was a problem hiding this comment.
@discordier Same here. The import is never called.
| trusted-keys: | ||
| # composer-require-checker | ||
| - 033E5F8D801A2F8D | ||
| - B2BDAAAC6F1FDE528CD9EEC9033E5F8D801A2F8D |
Member
There was a problem hiding this comment.
While these are not wrong, they point to a bug in phpcq... Apparently the cli of gnupg uses a different key fingerprint hash len than the php pgp extension.
We should fix this upstream and then remove them here again.
Member
Author
|
@discordier I've made a few updates. However, the "import" call has been removed from the phpunit section. Could you please take another look at it via the pull request? |
discordier
requested changes
Jan 28, 2026
| $this->assertInstanceof(Config::class, $parameters[0]); | ||
| $this->assertSame('Config', $parameters[1]); | ||
| }); | ||
| ->with(Config::class, 'Config'); |
Member
There was a problem hiding this comment.
When using never, "with" doesn't make sense at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please explain the detailed changes you made here.
Reference any issue number this pull request fixes.
Checklist
@authorsin touched PHP files