Skip to content

Correct the deep copy and testing system #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stefanheimes wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Correct the deep copy and testing system #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22dba8c
Correct the deep copy and testing system
stefanheimes Jan 26, 2026
df34cf4
Correct a phpunit test
stefanheimes Jan 26, 2026
03910c6
Correct a test file.
stefanheimes Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/diagnostics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ '8.1', '8.2', '8.3' ]
php: [ '8.2', '8.3' ]
contao: [ '~4.13.0' ]
phpcq_install: [ 'update' ]
output: [ '-o github-action -o default' ]
Expand Down
11 changes: 11 additions & 0 deletions .phpcq.yaml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ phpcq:
phpunit:
version: ^1.0
signed: false
requirements:
phpunit:
version: ^11.5.48
psalm:
version: ^1.0
signed: false
Expand Down Expand Up @@ -39,22 +42,30 @@ phpcq:
trusted-keys:
# composer-require-checker
- 033E5F8D801A2F8D
- B2BDAAAC6F1FDE528CD9EEC9033E5F8D801A2F8D
Copy link
Member

@discordier discordier Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these are not wrong, they point to a bug in phpcq... Apparently the cli of gnupg uses a different key fingerprint hash len than the php pgp extension.

We should fix this upstream and then remove them here again.

# sb@sebastian-bergmann.de
- 4AA394086372C20A
- D8406D0D82947747293778314AA394086372C20A
# psalm
- 8A03EA3B385DBAA1
- 12CE0F1D262429A5
- 2DE50EB60C013FFFA831040D12CE0F1D262429A5
# magl@magll.net
- D2CCAC42F6295E7D
# PHP_CodeSniffer
- 31C7E470E2138192
- 5E6DDE998AB73B8E
- A978220305CD5C32
- 689DAD778FF08760E046228BA978220305CD5C32
- 97B02DD8E5071466
- D91D86963AF3A29B6520462297B02DD8E5071466
# Composer normalize
- C00543248C87FB13
- 0FDE18AE1D09E19F60F6B1CBC00543248C87FB13
# phpmd
- A4E55EA12C7C085C
- 9093F8B32E4815AA
- E7A745102ECC980F7338B3079093F8B32E4815AA

tasks:
fix:
Expand Down
11 changes: 9 additions & 2 deletions src/EventListener/BackendEventListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,18 @@ private function duplicateContentEntries(string $strTable, int $intSourceId, int
$arrContent['pid'] = $intDestinationId;
unset($arrContent['id']);

$parameters = [];
foreach (array_keys($arrContent) as $key) {
$parameters[$key] = '?';
}

$this->connection
->createQueryBuilder()
->insert('tl_content')
->setParameters($arrContent)
->executeQuery();
->values($parameters)
->setParameters(array_values($arrContent))
->executeStatement()
;
}
}
}
4 changes: 2 additions & 2 deletions tests/Widgets/ContentArticleWidgetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,9 @@ public function testNewInstance(): void
->getMock();

$widget
->expects(self::any())
->expects($this->never())
->method('import')
->withConsecutive([Config::class, 'Config']);
Copy link
Member

@discordier discordier Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this whole block rathe be:

        $widget
            ->expects($this->once())
            ->method('import')
            ->with(Config::class, 'Config');

Copy link
Member Author

@stefanheimes stefanheimes Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@discordier Same here. The import is never called.

->with(Config::class, 'Config');
Copy link
Member

@discordier discordier Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using never, "with" doesn't make sense at all.


self::assertEmpty($widget->getAttributes());
}
Expand Down