chore(metrics): fixed cardinality leak on extract_error_metadata/1#42
Merged
Merged
Conversation
MikaAK
reviewed
Apr 21, 2026
| %ErrorMessage{code: code, message: error} -> "#{code}: #{error}" | ||
| %ErrorMessage{code: code} -> code | ||
| reason when is_atom(reason) -> to_string(reason) | ||
| reason when is_binary(reason) -> reason |
Owner
There was a problem hiding this comment.
I think the string is still needed for those who use string messages!
cking222
force-pushed
the
fix_extract_error_metadata_cardinality_bug
branch
from
36cb083 to
803ba8b
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 83.46% 83.46%
=======================================
Files 22 22
Lines 617 617
=======================================
Hits 515 515
Misses 102 102 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was observed as negatively impacting our prom scrape this morning.