Skip to content

chore(metrics): fixed cardinality leak on extract_error_metadata/1 #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MikaAK merged 1 commit into from
Apr 21, 2026
Merged

chore(metrics): fixed cardinality leak on extract_error_metadata/1 #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cache/metrics.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ if Application.ensure_loaded(:prometheus_telemetry) === :ok do
metadata
|> Map.take([:error, :cache_name])
|> Map.update(:error, "unknown", fn
%ErrorMessage{code: code, message: error} -> "#{code}: #{error}"
%ErrorMessage{code: code} -> code
reason when is_atom(reason) -> to_string(reason)
reason when is_binary(reason) -> reason
Copy link
Copy Markdown
Owner

@MikaAK MikaAK Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the string is still needed for those who use string messages!

_ -> "unknown"
Expand Down
Loading