Skip to content

GEOPY-2128: fix UI json version tests (part of GEOPY-2049)#190

Merged
sebhmg merged 6 commits intorelease/0.3.0from
GEOPY-2049-ui-json-version-tests
Apr 14, 2025
Merged

GEOPY-2128: fix UI json version tests (part of GEOPY-2049)#190
sebhmg merged 6 commits intorelease/0.3.0from
GEOPY-2049-ui-json-version-tests

Conversation

@sebhmg
Copy link
Contributor

@sebhmg sebhmg commented Apr 13, 2025

GEOPY-2128 - fix UI json version tests with new version

@github-actions github-actions bot changed the title Geopy 2049 UI json version tests GEOPY-2049: UI json version tests Apr 13, 2025
@sebhmg sebhmg changed the title GEOPY-2049: UI json version tests GEOPY-2049: fix UI json version tests Apr 13, 2025
@sebhmg sebhmg requested review from benk-mira, Copilot and domfournier and removed request for benk-mira and domfournier April 13, 2025 22:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

simpeg_drivers/uijson.py:61

  • [nitpick] Consider adding a clarifying comment to explain why non-RC pre-release identifiers are concatenated directly while RC versions are normalized to the base version.
if version.pre is not None and version.pre[0] != "rc":  # pylint: disable=unsubscriptable-object

tests/uijson_test.py:138

  • [nitpick] Consider renaming 'warning_message' to 'expected_warning' to better convey its intent in the test and reduce potential fragility if the message format changes.
warning_message = f"version '{version_input}' does not match the current simpeg-drivers version"

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (3df0708) to head (7c01224).
Report is 32 commits behind head on release/0.3.0.

Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.3.0     #190      +/-   ##
=================================================
+ Coverage          90.32%   90.33%   +0.01%     
=================================================
  Files                 87       87              
  Lines               5042     5051       +9     
  Branches             642      643       +1     
=================================================
+ Hits                4554     4563       +9     
  Misses               326      326              
  Partials             162      162              
Files with missing lines Coverage Δ
simpeg_drivers/uijson.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebhmg sebhmg changed the title GEOPY-2049: fix UI json version tests GEOPY-2128: fix UI json version tests (part of GEOPY-2049) Apr 14, 2025
@sebhmg sebhmg merged commit 2ce81d3 into release/0.3.0 Apr 14, 2025
12 of 14 checks passed
@sebhmg sebhmg deleted the GEOPY-2049-ui-json-version-tests branch April 14, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants