GEOPY-2128: fix UI json version tests (part of GEOPY-2049)#190
Merged
sebhmg merged 6 commits intorelease/0.3.0from Apr 14, 2025
Merged
GEOPY-2128: fix UI json version tests (part of GEOPY-2049)#190sebhmg merged 6 commits intorelease/0.3.0from
sebhmg merged 6 commits intorelease/0.3.0from
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
simpeg_drivers/uijson.py:61
- [nitpick] Consider adding a clarifying comment to explain why non-RC pre-release identifiers are concatenated directly while RC versions are normalized to the base version.
if version.pre is not None and version.pre[0] != "rc": # pylint: disable=unsubscriptable-object
tests/uijson_test.py:138
- [nitpick] Consider renaming 'warning_message' to 'expected_warning' to better convey its intent in the test and reduce potential fragility if the message format changes.
warning_message = f"version '{version_input}' does not match the current simpeg-drivers version"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.3.0 #190 +/- ##
=================================================
+ Coverage 90.32% 90.33% +0.01%
=================================================
Files 87 87
Lines 5042 5051 +9
Branches 642 643 +1
=================================================
+ Hits 4554 4563 +9
Misses 326 326
Partials 162 162
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2128 - fix UI json version tests with new version