Skip to content

GEOPY-2274: update scikit-learn to >=1.5.0 addressing potential vulnerability#243

Merged
sebhmg merged 6 commits intodevelopfrom
GEOPY-2274b
Aug 7, 2025
Merged

GEOPY-2274: update scikit-learn to >=1.5.0 addressing potential vulnerability#243
sebhmg merged 6 commits intodevelopfrom
GEOPY-2274b

Conversation

@MatthieuCMira
Copy link
Contributor

@MatthieuCMira MatthieuCMira commented Jul 29, 2025

GEOPY-2274 - update scikit-learn to >=1.5.0 addressing potential vulnerability
update recipe.yml

@MatthieuCMira MatthieuCMira requested a review from sebhmg July 29, 2025 14:23
@github-actions github-actions bot changed the title GEOPY-2274 GEOPY-2274: update scikit-learn to >=1.5.0 addressing potential vulnerability Jul 29, 2025
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong upper version constraint in recipe

@MatthieuCMira MatthieuCMira requested a review from sebhmg July 29, 2025 18:28
sebhmg
sebhmg previously approved these changes Jul 29, 2025
# Conflicts:
#	environments/py-3.10-linux-64-dev.conda.lock.yml
#	environments/py-3.10-linux-64.conda.lock.yml
#	environments/py-3.10-win-64-dev.conda.lock.yml
#	environments/py-3.10-win-64.conda.lock.yml
#	environments/py-3.11-linux-64-dev.conda.lock.yml
#	environments/py-3.11-linux-64.conda.lock.yml
#	environments/py-3.11-win-64-dev.conda.lock.yml
#	environments/py-3.11-win-64.conda.lock.yml
#	environments/py-3.12-linux-64-dev.conda.lock.yml
#	environments/py-3.12-linux-64.conda.lock.yml
#	environments/py-3.12-win-64-dev.conda.lock.yml
#	environments/py-3.12-win-64.conda.lock.yml
#	py-3.10.conda-lock.yml
#	py-3.11.conda-lock.yml
#	py-3.12.conda-lock.yml
Copy link
Contributor

@sebhmg sebhmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not revert the merge of develop, as it will apply that revert when merging back to develop, effectively resulting in reverting code from the develop

…ope all is well at runtime...

openmp will weight some more on disk,
and it is unclear if simpeg using mkl will play well with numpy using openblas.

See the origin of the problem here: conda-forge/conda-forge-repodata-patches-feedstock#1057
@sebhmg sebhmg requested a review from domfournier August 7, 2025 15:42
@sebhmg sebhmg merged commit 7bd2ed9 into develop Aug 7, 2025
14 checks passed
@sebhmg sebhmg deleted the GEOPY-2274b branch August 7, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants