Integrated heat storage and e-conversion asset#396
Merged
FJanssen-TNO merged 30 commits intomainfrom Mar 31, 2026
Merged
Conversation
…d using electricity
# Conflicts: # src/mesido/pycml/component_library/milp/__init__.py # src/mesido/pycml/component_library/milp/multicommodity/__init__.py
FJanssen-TNO
commented
Feb 19, 2026
src/mesido/pycml/component_library/milp/multicommodity/heat_buffer_elec.py
Outdated
Show resolved
Hide resolved
tests/models/heat_electricity_components/model/sourcesink_with_heater_ebuffer.esdl
Show resolved
Hide resolved
# Conflicts: # tests/test_electric_source_sink.py
Collaborator
|
@FJanssen-TNO Ready for review |
FJanssen-TNO
commented
Mar 10, 2026
src/mesido/pycml/component_library/milp/multicommodity/heat_buffer_elec.py
Outdated
Show resolved
Hide resolved
tests/models/heat_electricity_components/model/sourcesink_with_heater_ebuffer.esdl
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md # src/mesido/esdl/esdl_heat_model.py
FJanssen-TNO
commented
Mar 18, 2026
src/mesido/pycml/component_library/milp/multicommodity/heat_buffer_elec.py
Outdated
Show resolved
Hide resolved
# Conflicts: # src/mesido/esdl/asset_to_component_base.py # src/mesido/esdl/esdl_model_base.py
FJanssen-TNO
commented
Mar 27, 2026
Collaborator
Author
FJanssen-TNO
left a comment
There was a problem hiding this comment.
Few final comments.
KobusVanRooyen
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create an integrated heat storage asset that can be charged using electricity.
Using a heatbuffer with an additional electricity port.
ToDo:
Note: