fix(server): revert playwright spawn to npx — node cli.js exits immediately on Windows#124
Merged
Merged
Conversation
…iately on Windows Direct node spawn with shell:false does not replicate the Windows console handle inheritance that cmd.exe provides; playwright exits with no output. Reverts to npx playwright with shell:true on win32. The non-blocking remote warmup (the real startup speedup) is preserved. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe server updates two Playwright SSE streaming endpoints to spawn Playwright processes via ChangesPlaywright Process Spawning
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #122 replaced npx playwright with node @playwright/test/cli.js (shell: false). On Windows, spawning without cmd.exe means playwright exits immediately with no output — tests appear "done" the instant Run Tests is clicked.
Reverts the spawn back to npx playwright with shell: process.platform === 'win32'. The non-blocking remote warmup (the real startup speedup from #122) is preserved.
Summary by CodeRabbit