Skip to content

fix(server): revert playwright spawn to npx — node cli.js exits immediately on Windows #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MyNameIsEdi merged 1 commit into from
May 25, 2026
Merged

fix(server): revert playwright spawn to npx — node cli.js exits immediately on Windows #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1137,6 +1137,7 @@ app.get('/api/playwright/artifacts', (_req, res) => {
}
});


app.post('/api/playwright/run', async (req, res) => {
const {
spec,
Expand Down Expand Up @@ -1250,13 +1251,10 @@ app.post('/api/playwright/run', async (req, res) => {
})();
}

// Use the local playwright CLI directly — avoids npx resolution overhead
// (saves 30-90s on Windows where npx+shell startup is expensive).
const pwCli = path.join(root, 'node_modules', '@playwright', 'test', 'cli.js');
const child = spawn(process.execPath, [pwCli, ...args], {
const child = spawn('npx', ['playwright', ...args], {
cwd: root,
env,
shell: false,
shell: process.platform === 'win32',
});

// Capture log lines so they're (a) persisted with the archived run and
Expand Down Expand Up @@ -1590,11 +1588,10 @@ app.post('/api/run-dynamic-test', async (req, res) => {
PW_RUNTIME_CONFIG: JSON.stringify({ testMatch: ['**/_dynamic_agent_test.spec.ts'] }),
};

const pwCli = path.join(root, 'node_modules', '@playwright', 'test', 'cli.js');
const child = spawn(process.execPath, [pwCli, 'test'], {
const child = spawn('npx', ['playwright', 'test'], {
cwd: root,
env,
shell: false,
shell: process.platform === 'win32',
});

// Capture every log line so we can persist them with the archived run.
Expand Down
Loading